From: Jiri Pirko <jpirko@redhat.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
bhutchings@solarflare.com, shemminger@vyatta.com,
fubar@us.ibm.com, andy@greyhouse.net, tgraf@infradead.org,
ebiederm@xmission.com, mirqus@gmail.com, kaber@trash.net,
greearb@candelatech.com, jesse@nicira.com, fbl@redhat.com,
benjamin.poirier@gmail.com, jzupka@redhat.com,
ivecera@redhat.com
Subject: Re: [patch net-next V7] net: introduce ethernet teaming device
Date: Thu, 10 Nov 2011 17:59:45 +0100 [thread overview]
Message-ID: <20111110165944.GA2078@minipsycho> (raw)
In-Reply-To: <1320940930.10042.2.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
Thu, Nov 10, 2011 at 05:02:10PM CET, eric.dumazet@gmail.com wrote:
>Le jeudi 10 novembre 2011 à 16:41 +0100, Jiri Pirko a écrit :
>> This patch introduces new network device called team. It supposes to be
>> very fast, simple, userspace-driven alternative to existing bonding
>> driver.
>>
>
>> +static bool team_dummy_transmit(struct team *team, struct sk_buff *skb)
>> +{
>> + dev_kfree_skb(skb);
>> + return false;
>> +}
>> +
>
>ndo_start_xmit() method can be called with IRQ disabled (netpoll ?), so
>dev_kfree_skb_any() is better ?
>
For example bonding is using dev_kfree_skb in xmit as well.
I propose this to be eventually addressed in follow-up patch.
>
>
next prev parent reply other threads:[~2011-11-10 17:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-10 15:41 [patch net-next V7] net: introduce ethernet teaming device Jiri Pirko
2011-11-10 16:02 ` Eric Dumazet
2011-11-10 16:59 ` Jiri Pirko [this message]
2011-11-11 18:04 ` Flavio Leitner
2011-11-11 19:05 ` Flavio Leitner
2011-11-11 19:58 ` Flavio Leitner
2011-11-12 0:15 ` Jiri Pirko
2011-11-12 5:45 ` David Miller
2011-11-12 8:18 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111110165944.GA2078@minipsycho \
--to=jpirko@redhat.com \
--cc=andy@greyhouse.net \
--cc=benjamin.poirier@gmail.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=eric.dumazet@gmail.com \
--cc=fbl@redhat.com \
--cc=fubar@us.ibm.com \
--cc=greearb@candelatech.com \
--cc=ivecera@redhat.com \
--cc=jesse@nicira.com \
--cc=jzupka@redhat.com \
--cc=kaber@trash.net \
--cc=mirqus@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
--cc=tgraf@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).