From: David Miller <davem@davemloft.net>
To: horti@google.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
david.decotigny@google.com, ian.campbell@citrix.com,
rick.jones2@hp.com, eric.dumazet@gmail.com, maheshb@google.com
Subject: Re: [PATCH net-next v1] net-forcedeth: Add internal loopback support for forcedeth NICs.
Date: Fri, 11 Nov 2011 20:28:07 -0500 (EST) [thread overview]
Message-ID: <20111111.202807.1335209533396648252.davem@davemloft.net> (raw)
In-Reply-To: <177427773f155c883809613ddf1ce28546aaac3e.1320871300.git.horti@google.com>
From: Sanjay Hortikar <horti@google.com>
Date: Wed, 9 Nov 2011 12:45:25 -0800
> @@ -5124,6 +5266,12 @@ static int nv_open(struct net_device *dev)
>
> spin_unlock_irq(&np->lock);
>
> + /* If the loopback feature was set while the device was down, make sure
> + * that it's set correctly now.
> + */
Improperly formatted comment, it should be:
/*
*
*/
> @@ -5328,6 +5476,10 @@ static int __devinit nv_probe(struct pci_dev *pci_dev, const struct pci_device_i
>
> dev->features |= dev->hw_features;
>
> + /* Add loopback capability to the device. */
> + dev->hw_features |= NETIF_F_LOOPBACK;
> +
> +
> np->pause_flags = NV_PAUSEFRAME_RX_CAPABLE | NV_PAUSEFRAME_RX_REQ | NV_PAUSEFRAME_AUTONEG;
Please do not add all of these extra empty lines.
prev parent reply other threads:[~2011-11-12 1:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1320871300.git.horti@google.com>
2011-11-09 20:45 ` [PATCH net-next v1] net-forcedeth: Add internal loopback support for forcedeth NICs Sanjay Hortikar
2011-11-12 1:28 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111111.202807.1335209533396648252.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=david.decotigny@google.com \
--cc=eric.dumazet@gmail.com \
--cc=horti@google.com \
--cc=ian.campbell@citrix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maheshb@google.com \
--cc=netdev@vger.kernel.org \
--cc=rick.jones2@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).