From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH] brcmsmac: Use current logging styles Date: Sun, 13 Nov 2011 17:08:25 -0800 Message-ID: <20111113170825.6633b17e@nehalam.linuxnetplumber.net> References: <1321213264.15834.4.camel@Joe-Laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Arend van Spriel , "John W. Linville" , linux-wireless , netdev , LKML To: Joe Perches Return-path: In-Reply-To: <1321213264.15834.4.camel@Joe-Laptop> Sender: linux-wireless-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org On Sun, 13 Nov 2011 11:41:04 -0800 Joe Perches wrote: > Add and use pr_fmt and pr_ > Remove useless double parentheses from macros. > Remove function names from format strings, add to pr_debug use. > Coalesce formats. > Remove uncompileable undeclared variable in a DMA_NONE use. If you are going to change it why not got all the way to netdev_XXX and dev_XXX macros instead. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html