netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: yevgenyp@mellanox.co.il
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH Fix] mlx4_en: Remove FCS bytes from packet length.
Date: Mon, 14 Nov 2011 00:13:30 -0500 (EST)	[thread overview]
Message-ID: <20111114.001330.804008773505285450.davem@davemloft.net> (raw)
In-Reply-To: <4EBF733E.5020801@mellanox.co.il>

From: Yevgeny Petrilin <yevgenyp@mellanox.co.il>
Date: Sun, 13 Nov 2011 09:35:26 +0200

> diff --git a/drivers/net/ethernet/mellanox/mlx4/mlx4_en.h b/drivers/net/ethernet/mellanox/mlx4/mlx4_en.h
> index 8fda331c..d93476b 100644
> --- a/drivers/net/ethernet/mellanox/mlx4/mlx4_en.h
> +++ b/drivers/net/ethernet/mellanox/mlx4/mlx4_en.h
> @@ -140,6 +140,7 @@ enum {
>  #define MLX4_EN_TX_POLL_TIMEOUT	(HZ / 4)
>  
>  #define ETH_LLC_SNAP_SIZE	8
> +#define FCS_SIZE		4
>  

Please use ETH_FCS_LEN from linux/if_ether.h

      reply	other threads:[~2011-11-14  5:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-13  7:35 [PATCH Fix] mlx4_en: Remove FCS bytes from packet length Yevgeny Petrilin
2011-11-14  5:13 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111114.001330.804008773505285450.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=yevgenyp@mellanox.co.il \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).