From: David Miller <davem@davemloft.net>
To: holger.brunck@keymile.com
Cc: netdev@vger.kernel.org, wolfgang.fritz@keymile.com,
shemminger@linux-foundation.org,
bridge@lists.linux-foundation.org
Subject: Re: [PATCH] net, bridge: print log message after state changed
Date: Mon, 14 Nov 2011 00:37:02 -0500 (EST) [thread overview]
Message-ID: <20111114.003702.1097206603722725705.davem@davemloft.net> (raw)
In-Reply-To: <1320941934-3534-1-git-send-email-holger.brunck@keymile.com>
From: Holger Brunck <holger.brunck@keymile.com>
Date: Thu, 10 Nov 2011 17:18:54 +0100
> From: Wolfgang Fritz <wolfgang.fritz@keymile.com>
>
> Function br_log_state writes log message "... entering XXXX state" so it
> should be called after the state has changed and not before.
>
> Signed-off-by: Wolfgang Fritz <wolfgang.fritz@keymile.com>
> Signed-off-by: Holger Brunck <holger.brunck@keymile.com>
"entering" can roughly mean "about to enter"
The message is therefore appropriately timed as far as I'm concerned.
I'm not applying this patch.
next prev parent reply other threads:[~2011-11-14 5:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-10 16:18 [PATCH] net, bridge: print log message after state changed Holger Brunck
2011-11-14 5:37 ` David Miller [this message]
2011-11-14 7:03 ` Fritz, Wolfgang
2011-11-14 7:07 ` David Miller
2011-11-14 9:10 ` Fritz, Wolfgang
2011-11-14 14:27 ` Joe Perches
2011-11-17 19:23 ` David Lamparter
2011-11-17 22:40 ` Stephen Hemminger
2011-11-18 9:20 ` Holger Brunck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111114.003702.1097206603722725705.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bridge@lists.linux-foundation.org \
--cc=holger.brunck@keymile.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
--cc=wolfgang.fritz@keymile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).