netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: amirv@dev.mellanox.co.il
Cc: netdev@vger.kernel.org, oren@mellanox.com, yevgenyp@mellanox.com,
	ogerlitz@mellanox.com, amirv@mellanox.co.il
Subject: Re: [PATCH 1/3] net/mlx4_en: allow setting number of rx rings for RSS/TCP
Date: Tue, 15 Nov 2011 16:49:24 -0500 (EST)	[thread overview]
Message-ID: <20111115.164924.433752545055710503.davem@davemloft.net> (raw)
In-Reply-To: <1321348446-29605-2-git-send-email-amirv@mellanox.com>

From: Amir Vadai <amirv@dev.mellanox.co.il>
Date: Tue, 15 Nov 2011 11:14:04 +0200

> +	if (priv->mdev->profile.tcp_rss == -1 ||
> +			priv->mdev->profile.tcp_rss > priv->rx_ring_num)

Please format your code properly:

	if (priv->mdev->profile.tcp_rss == -1 ||
	    priv->mdev->profile.tcp_rss > priv->rx_ring_num)

  reply	other threads:[~2011-11-15 21:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-15  9:14 [PATCH 0/3] mlx4_en: loopback support + RSS TCP improve + bug fix Amir Vadai
2011-11-15  9:14 ` [PATCH 1/3] net/mlx4_en: allow setting number of rx rings for RSS/TCP Amir Vadai
2011-11-15 21:49   ` David Miller [this message]
2011-11-15  9:14 ` [PATCH 2/3] net/mlx4_en: adding loopback support Amir Vadai
2011-11-15  9:14 ` [PATCH 3/3] net/mlx4_en: bug fix for the case of vlan id 0 and UP 0 Amir Vadai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111115.164924.433752545055710503.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=amirv@dev.mellanox.co.il \
    --cc=amirv@mellanox.co.il \
    --cc=netdev@vger.kernel.org \
    --cc=ogerlitz@mellanox.com \
    --cc=oren@mellanox.com \
    --cc=yevgenyp@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).