From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Todd Broch <tbroch@chromium.org>
Cc: Francois Romieu <romieu@fr.zoreil.com>,
Realtek linux nic maintainers <nic_swsd@realtek.com>,
netdev@vger.kernel.org, Hayes Wang <hayeswang@realtek.com>
Subject: Re: [PATCH] r8169: add module param for control of ASPM disable
Date: Tue, 15 Nov 2011 16:32:40 +0000 [thread overview]
Message-ID: <20111115163240.GA5549@srcf.ucam.org> (raw)
In-Reply-To: <CA+iF6Rog3ptpmQZzhcRODmZUKN18_uw5t9xfpQjbJ86qKUA0eQ@mail.gmail.com>
On Tue, Nov 15, 2011 at 08:27:41AM -0800, Todd Broch wrote:
> On Sat, Nov 12, 2011 at 2:46 AM, Francois Romieu <romieu@fr.zoreil.com>wrote:
> >
> > Re-visiting the original change that disabled ASPM,
>
> http://www.google.com/url?q=http%3A//git.kernel.org/%3Fp%3Dlinux/kernel/git/torvalds/linux-2.6.git%3Ba%3Dcommit%3Bh%3Dba04c7c93bbcb48ce880cf75b6e9dffcd79d4c7b&usg=AFQjCNFfPARrhwg-nBtW09W_n4qr1hgvdA
>
> Led me to,
> https://bugzilla.redhat.com/show_bug.cgi?id=642861#c4
>
> This comment by tomi.leppikangas@, is later re-canted as a h/w issue in,
> https://bugzilla.redhat.com/show_bug.cgi?id=642861#c9
> 'I am now pretty sure that my problems were caused by faulty hardware.
> Cpu or
> motherboard seems to be broken, so pcie_aspm=off didnt help for me.
> Sorry
> about misleading info.'
Mike Khusid's issue was fixed by disabling ASPM.
> My assement from above is that ASPM was disabled prematurely and given the
> power
> savings should be re-enabled.
Power savings are great. I'm all in favour of power savings. But not
when they break otherwise working setups.
> I'd certainly be agreeable to switching the assertion of patch to default
> being disabled.
> Unfortunately I fear that means most will never benefit from the power
> savings.
I'd recommend working with your hardware partners to figure out which
parts are expected to work and which aren't. There's no problem with
making this code conditional on product ID or version.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2011-11-15 16:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-11 23:05 [PATCH] r8169: add module param for control of ASPM disable Todd Broch
2011-11-12 4:59 ` Matthew Garrett
2011-11-12 10:46 ` Francois Romieu
[not found] ` <CA+iF6Rog3ptpmQZzhcRODmZUKN18_uw5t9xfpQjbJ86qKUA0eQ@mail.gmail.com>
2011-11-15 16:32 ` Matthew Garrett [this message]
2011-11-17 9:37 ` Francois Romieu
[not found] ` <CA+iF6RqKScip+6w-tzo3sF+hEsYDUefED29KEBrx5TDaZaTEbA@mail.gmail.com>
2011-11-17 21:26 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111115163240.GA5549@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=hayeswang@realtek.com \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=romieu@fr.zoreil.com \
--cc=tbroch@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).