* [PATCH] r6040: fix check against MCRO_HASHEN bit in r6040_multicast_list
@ 2011-11-16 16:00 Florian Fainelli
2011-11-17 1:35 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Florian Fainelli @ 2011-11-16 16:00 UTC (permalink / raw)
To: davem; +Cc: netdev, Florian Fainelli
We are checking whether the MCR0_HASHEN bit is set using a logical and
instead of bitwise and, fix that.
Signed-off-by: Florian Fainelli <florian@openwrt.org>
---
drivers/net/ethernet/rdc/r6040.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ethernet/rdc/r6040.c b/drivers/net/ethernet/rdc/r6040.c
index 1fc01ca..4bf68cf 100644
--- a/drivers/net/ethernet/rdc/r6040.c
+++ b/drivers/net/ethernet/rdc/r6040.c
@@ -940,7 +940,7 @@ static void r6040_multicast_list(struct net_device *dev)
iowrite16(lp->mcr0, ioaddr + MCR0);
/* Fill the MAC hash tables with their values */
- if (lp->mcr0 && MCR0_HASH_EN) {
+ if (lp->mcr0 & MCR0_HASH_EN) {
iowrite16(hash_table[0], ioaddr + MAR0);
iowrite16(hash_table[1], ioaddr + MAR1);
iowrite16(hash_table[2], ioaddr + MAR2);
--
1.7.5.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] r6040: fix check against MCRO_HASHEN bit in r6040_multicast_list
2011-11-16 16:00 [PATCH] r6040: fix check against MCRO_HASHEN bit in r6040_multicast_list Florian Fainelli
@ 2011-11-17 1:35 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2011-11-17 1:35 UTC (permalink / raw)
To: florian; +Cc: netdev
From: Florian Fainelli <florian@openwrt.org>
Date: Wed, 16 Nov 2011 17:00:08 +0100
> We are checking whether the MCR0_HASHEN bit is set using a logical and
> instead of bitwise and, fix that.
>
> Signed-off-by: Florian Fainelli <florian@openwrt.org>
Applied, thank you.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-11-17 1:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-16 16:00 [PATCH] r6040: fix check against MCRO_HASHEN bit in r6040_multicast_list Florian Fainelli
2011-11-17 1:35 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).