From: David Miller <davem@davemloft.net>
To: peppe.cavallaro@st.com
Cc: netdev@vger.kernel.org, francesco.virlinzi@st.com,
srinivas.kandagatla@st.com
Subject: Re: [PATCH 4/5] stmmac: remove spin_lock in stmmac_ioctl.
Date: Thu, 17 Nov 2011 03:14:30 -0500 (EST) [thread overview]
Message-ID: <20111117.031430.491721529337695679.davem@davemloft.net> (raw)
In-Reply-To: <1321516682-32208-4-git-send-email-peppe.cavallaro@st.com>
From: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
Date: Thu, 17 Nov 2011 08:58:01 +0100
> From: Srinivas Kandagatla <srinivas.kandagatla@st.com>
>
> This patch removes un-needed spin_lock in stmmac_ioctl while reading and
> writing mdio registers. While holding spin_lock the code must be
> atomic, which is not true in this case as both mdiobus_read and writes
> have mutex locks.
>
> Without this patch reading mdio registers via mii-tool results in below
> BUG:
> mii-tool -vvv eth0"
> Using SIOCGMIIPHY=0x8947
> BUG: sleeping function called from invalid context at kernel/mutex.c:287
...
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@st.com>
> Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>
Applied.
next prev parent reply other threads:[~2011-11-17 8:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-17 7:57 [PATCH 1/5] stmmac: use mdelay on timeout of sw reset Giuseppe CAVALLARO
2011-11-17 7:57 ` [PATCH 2/5] stmmac: fix advertising 1000Base capabilties for non GMII iface Giuseppe CAVALLARO
2011-11-17 8:14 ` David Miller
2011-11-17 7:58 ` [PATCH 3/5] stmmac: parameters auto-tuning through HW cap reg Giuseppe CAVALLARO
2011-11-17 8:14 ` David Miller
2011-11-17 7:58 ` [PATCH 4/5] stmmac: remove spin_lock in stmmac_ioctl Giuseppe CAVALLARO
2011-11-17 8:14 ` David Miller [this message]
2011-11-17 7:58 ` [PATCH 5/5] stmmac: fix pm functions avoiding sleep on spinlock Giuseppe CAVALLARO
2011-11-17 8:14 ` David Miller
2011-11-17 8:13 ` [PATCH 1/5] stmmac: use mdelay on timeout of sw reset David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111117.031430.491721529337695679.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=francesco.virlinzi@st.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=srinivas.kandagatla@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).