netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: fbl@redhat.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] route: add more relaxed option for secure_redirects
Date: Thu, 17 Nov 2011 16:53:09 -0500 (EST)	[thread overview]
Message-ID: <20111117.165309.1283667903570988053.davem@davemloft.net> (raw)
In-Reply-To: <20111116234042.6ad8d723@asterix.rh>

From: Flavio Leitner <fbl@redhat.com>
Date: Wed, 16 Nov 2011 23:40:42 -0200

> To make sure we are in the same page, this simple setup reproduces
> the issue.
> 
> IP: 10.0.0.1
> gw: 10.0.0.100
> +--------+          +-----+ primary: 10.0.0.2
> | client |----+-----| GW1 |   alias: 10.0.0.100
> +--------+    |     +-----+      gw: 10.0.0.254
>            +--+--+
>            | GW2 |---> internet
>            +-----+
>          10.0.0.254
> 
> 1. Client sends TCP SYN to an internet host using
>    GW1 alias address as default gw address
> 
> 2. Then GW1 sends the ICMP redirect back to client
>    using the primary address as source address.
> 
> 3. GW1 forwards the original packet to GW2
> 
> 4. client ignores the ICMP redirect because
>    client.gw != gw1.primary.

GW1 must respond using a source address matching 'alias', ie.
10.0.0.100 and I would accept a mechinsm to make sure that happens,
if not by default then via a sysctl or similar control.

      parent reply	other threads:[~2011-11-17 21:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-07 15:41 [PATCH] route: fix ICMP secure_redirects Flavio Leitner
2011-11-07 18:35 ` David Miller
2011-11-07 19:05   ` Flavio Leitner
2011-11-08  0:03     ` [PATCH] route: add more relaxed option for secure_redirects Flavio Leitner
2011-11-12  1:33       ` David Miller
2011-11-16 20:46         ` Flavio Leitner
2011-11-16 22:02           ` David Miller
2011-11-16 23:17             ` Flavio Leitner
2011-11-17  1:40               ` Flavio Leitner
2011-11-17  1:41                 ` David Miller
2011-11-17 21:53                 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111117.165309.1283667903570988053.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=fbl@redhat.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).