From: David Miller <davem@davemloft.net>
To: nicolas.2p.debian@gmail.com
Cc: vfalico@redhat.com, netdev@vger.kernel.org, andy@greyhouse.net,
fubar@us.ibm.com
Subject: Re: [PATCH] bonding: Don't allow mode change via sysfs with slaves present
Date: Thu, 17 Nov 2011 19:32:29 -0500 (EST) [thread overview]
Message-ID: <20111117.193229.204248404169838998.davem@davemloft.net> (raw)
In-Reply-To: <4EC58C89.7020906@gmail.com>
From: Nicolas de Pesloüan <nicolas.2p.debian@gmail.com>
Date: Thu, 17 Nov 2011 23:36:57 +0100
> Le 17/11/2011 22:04, David Miller a écrit :
>> From: Veaceslav Falico<vfalico@redhat.com>
>> Date: Tue, 15 Nov 2011 17:44:42 +0100
>>
>>> When changing mode via bonding's sysfs, the slaves are not initialized
>>> correctly. Forbid to change modes with slaves present to ensure that
>>> every
>>> slave is initialized correctly via bond_enslave().
>>>
>>> Signed-off-by: Veaceslav Falico<vfalico@redhat.com>
>>
>> Lots of discussion... what is the final verdict on this patch bonding
>> folks?
>
> Now looks good to me, and as all others participants agreed at the
> beginning, I think it's good for everyone.
Great, applied, thanks everyone.
prev parent reply other threads:[~2011-11-18 0:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-15 16:44 [PATCH] bonding: Don't allow mode change via sysfs with slaves present Veaceslav Falico
2011-11-15 17:00 ` Andy Gospodarek
2011-11-15 19:24 ` Nicolas de Pesloüan
2011-11-15 19:33 ` Ben Hutchings
2011-11-15 19:35 ` Andy Gospodarek
2011-11-15 20:02 ` Nicolas de Pesloüan
2011-11-15 20:47 ` Andy Gospodarek
2011-11-16 12:02 ` Nicolas de Pesloüan
2011-11-16 22:02 ` Andy Gospodarek
2011-11-17 1:16 ` Flavio Leitner
2011-11-17 21:28 ` Nicolas de Pesloüan
2011-11-15 21:04 ` Veaceslav Falico
2011-11-17 21:04 ` David Miller
2011-11-17 22:36 ` Nicolas de Pesloüan
2011-11-18 0:32 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111117.193229.204248404169838998.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andy@greyhouse.net \
--cc=fubar@us.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.2p.debian@gmail.com \
--cc=vfalico@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).