From: David Miller <davem@davemloft.net>
To: mchan@broadcom.com
Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org, eilong@broadcom.com
Subject: Re: [PATCH net-next] bnx2: switch to build_skb() infrastructure
Date: Fri, 18 Nov 2011 02:09:05 -0500 (EST) [thread overview]
Message-ID: <20111118.020905.956112543630839327.davem@davemloft.net> (raw)
In-Reply-To: <1321591644.8833.1.camel@HP1>
From: "Michael Chan" <mchan@broadcom.com>
Date: Thu, 17 Nov 2011 20:47:24 -0800
>
> On Tue, 2011-11-15 at 09:30 -0800, Eric Dumazet wrote:
>> This is very similar to bnx2x conversion, but bnx2 only requires 16bytes
>> alignement at start of the received frame to store its l2_fhdr, so goal
>> was not to reduce skb truesize (in fact it should not change after this
>> patch)
>>
>> Using build_skb() reduces cache line misses in the driver, since we
>> use cache hot skb instead of cold ones. Number of in-flight sk_buff
>> structures is lower, they are more likely recycled in SLUB caches
>> while still hot.
>>
>> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
>> CC: Michael Chan <mchan@broadcom.com>
>> CC: Eilon Greenstein <eilong@broadcom.com>
>
> Looks good. Thanks.
>
> Reviewed-by: Michael Chan <mchan@broadcom.com>
Applied, thanks everyone.
prev parent reply other threads:[~2011-11-18 7:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-15 17:30 [PATCH net-next] bnx2: switch to build_skb() infrastructure Eric Dumazet
2011-11-17 21:04 ` David Miller
2011-11-18 4:47 ` Michael Chan
2011-11-18 7:09 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111118.020905.956112543630839327.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eilong@broadcom.com \
--cc=eric.dumazet@gmail.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).