From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] xen-netfront: report link speed to ethtool Date: Fri, 18 Nov 2011 14:11:49 -0500 (EST) Message-ID: <20111118.141149.231957666935653299.davem@davemloft.net> References: <20111118164805.GA14345@aepfle.de> <1321638394.2883.32.camel@bwh-desktop> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: olaf@aepfle.de, netdev@vger.kernel.org, xen-devel@lists.xensource.com, jeremy.fitzhardinge@citrix.com, konrad.wilk@oracle.com To: bhutchings@solarflare.com Return-path: Received: from shards.monkeyblade.net ([198.137.202.13]:46339 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753969Ab1KRTOD (ORCPT ); Fri, 18 Nov 2011 14:14:03 -0500 In-Reply-To: <1321638394.2883.32.camel@bwh-desktop> Sender: netdev-owner@vger.kernel.org List-ID: From: Ben Hutchings Date: Fri, 18 Nov 2011 17:46:34 +0000 > On Fri, 2011-11-18 at 17:48 +0100, Olaf Hering wrote: >> Add .get_settings function, return fake data so that ethtool can get >> enough information. For some application like VCS, this is useful, >> otherwise some of application logic will get panic. >> The reported data refers to VMWare vmxnet. >> >> Signed-off-by: Xin Wei Hu >> Signed-off-by: Chunyan Liu >> Signed-off-by: Olaf Hering > > NAK, we should not just make things up. Agreed, if you cannot determine the values with certainty do not implement this method. Fix the tools which cannot function without this information.