From: David Miller <davem@davemloft.net>
To: bhutchings@solarflare.com
Cc: yevgenyp@mellanox.co.il, netdev@vger.kernel.org,
ogerlitz@mellanox.com, oren@mellanox.co.il, amirv@mellanox.co.il
Subject: Re: [PATCH 6/8] net/mlx4_en: allow setting number of rx rings for, RSS/TCP
Date: Mon, 21 Nov 2011 13:43:09 -0500 (EST) [thread overview]
Message-ID: <20111121.134309.970601561852715936.davem@davemloft.net> (raw)
In-Reply-To: <1321894651.2692.1.camel@bwh-desktop>
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Mon, 21 Nov 2011 16:57:30 +0000
> On Mon, 2011-11-21 at 10:43 +0200, Yevgeny Petrilin wrote:
>> From: Amir Vadai <amirv@mellanox.co.il>
>>
>> Make RSS TCP divert packets only to part of the rx rings, other could be
>> accessed by using flow steering or RFS acceleration
> [...]
>
> The ethtool {get,set}_rxfh_indir operations are a standard and more
> flexible interface for configuring this.
Agreed, you should _NEVER_ add module options or private driver extensions
for such a common configuration setting.
prev parent reply other threads:[~2011-11-21 18:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-21 8:43 [PATCH 6/8] net/mlx4_en: allow setting number of rx rings for, RSS/TCP Yevgeny Petrilin
2011-11-21 16:57 ` Ben Hutchings
2011-11-21 18:43 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111121.134309.970601561852715936.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=amirv@mellanox.co.il \
--cc=bhutchings@solarflare.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=oren@mellanox.co.il \
--cc=yevgenyp@mellanox.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).