* [PATCH] net, sja1000: Don't include version.h in peak_pci.c when not needed
@ 2011-11-20 21:07 Jesper Juhl
2011-11-21 9:51 ` Marc Kleine-Budde
0 siblings, 1 reply; 3+ messages in thread
From: Jesper Juhl @ 2011-11-20 21:07 UTC (permalink / raw)
To: linux-can, netdev
Cc: linux-kernel, Marc Kleine-Budde, David S. Miller,
Wolfgang Grandegger
It was pointed out by "make versioncheck" that we do not need to include
version.h in drivers/net/can/sja1000/peak_pci.c
This patch removes the unneeded include.
Signed-off-by: Jesper Juhl <jj@chaosbits.net>
---
drivers/net/can/sja1000/peak_pci.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
note: patch is compile tested only.
diff --git a/drivers/net/can/sja1000/peak_pci.c b/drivers/net/can/sja1000/peak_pci.c
index 905bce0..2c7f503 100644
--- a/drivers/net/can/sja1000/peak_pci.c
+++ b/drivers/net/can/sja1000/peak_pci.c
@@ -20,7 +20,6 @@
*/
#include <linux/kernel.h>
-#include <linux/version.h>
#include <linux/module.h>
#include <linux/interrupt.h>
#include <linux/netdevice.h>
--
1.7.7.3
--
Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net, sja1000: Don't include version.h in peak_pci.c when not needed
2011-11-20 21:07 [PATCH] net, sja1000: Don't include version.h in peak_pci.c when not needed Jesper Juhl
@ 2011-11-21 9:51 ` Marc Kleine-Budde
2011-11-21 21:44 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Marc Kleine-Budde @ 2011-11-21 9:51 UTC (permalink / raw)
To: Jesper Juhl
Cc: linux-can, netdev, linux-kernel, David S. Miller,
Wolfgang Grandegger
[-- Attachment #1: Type: text/plain, Size: 595 bytes --]
On 11/20/2011 10:07 PM, Jesper Juhl wrote:
> It was pointed out by "make versioncheck" that we do not need to include
> version.h in drivers/net/can/sja1000/peak_pci.c
> This patch removes the unneeded include.
>
> Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net, sja1000: Don't include version.h in peak_pci.c when not needed
2011-11-21 9:51 ` Marc Kleine-Budde
@ 2011-11-21 21:44 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2011-11-21 21:44 UTC (permalink / raw)
To: mkl; +Cc: jj, linux-can, netdev, linux-kernel, wg
From: Marc Kleine-Budde <mkl@pengutronix.de>
Date: Mon, 21 Nov 2011 10:51:15 +0100
> On 11/20/2011 10:07 PM, Jesper Juhl wrote:
>> It was pointed out by "make versioncheck" that we do not need to include
>> version.h in drivers/net/can/sja1000/peak_pci.c
>> This patch removes the unneeded include.
>>
>> Signed-off-by: Jesper Juhl <jj@chaosbits.net>
> Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>
Applied, thanks everyone.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-11-21 21:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-20 21:07 [PATCH] net, sja1000: Don't include version.h in peak_pci.c when not needed Jesper Juhl
2011-11-21 9:51 ` Marc Kleine-Budde
2011-11-21 21:44 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).