* [PATCH] dccp: fix error propagation in dccp_v4_connect
@ 2011-11-21 5:18 roy.qing.li
2011-11-21 21:45 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: roy.qing.li @ 2011-11-21 5:18 UTC (permalink / raw)
To: netdev
From: RongQing.Li <roy.qing.li@gmail.com>
The errcode is not updated when ip_route_newports() fails.
Signed-off-by: RongQing.Li <roy.qing.li@gmail.com>
---
net/dccp/ipv4.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/net/dccp/ipv4.c b/net/dccp/ipv4.c
index 90a919a..3f4e541 100644
--- a/net/dccp/ipv4.c
+++ b/net/dccp/ipv4.c
@@ -111,6 +111,7 @@ int dccp_v4_connect(struct sock *sk, struct sockaddr *uaddr, int addr_len)
rt = ip_route_newports(fl4, rt, orig_sport, orig_dport,
inet->inet_sport, inet->inet_dport, sk);
if (IS_ERR(rt)) {
+ err = PTR_ERR(rt);
rt = NULL;
goto failure;
}
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dccp: fix error propagation in dccp_v4_connect
2011-11-21 5:18 [PATCH] dccp: fix error propagation in dccp_v4_connect roy.qing.li
@ 2011-11-21 21:45 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2011-11-21 21:45 UTC (permalink / raw)
To: roy.qing.li; +Cc: netdev
From: roy.qing.li@gmail.com
Date: Mon, 21 Nov 2011 13:18:20 +0800
> From: RongQing.Li <roy.qing.li@gmail.com>
>
> The errcode is not updated when ip_route_newports() fails.
>
> Signed-off-by: RongQing.Li <roy.qing.li@gmail.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-11-21 21:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-21 5:18 [PATCH] dccp: fix error propagation in dccp_v4_connect roy.qing.li
2011-11-21 21:45 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).