From: David Miller <davem@davemloft.net>
To: sjurbren@gmail.com
Cc: dan.carpenter@oracle.com, viro@zeniv.linux.org.uk,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch v2] caif: fix endian conversion in cffrml_transmit()
Date: Mon, 21 Nov 2011 16:46:43 -0500 (EST) [thread overview]
Message-ID: <20111121.164643.58544532996822474.davem@davemloft.net> (raw)
In-Reply-To: <CAJK669bL51Ct-Q9LxXwFdiaQAnfkx2Um1k0Cutci2z6mdd2THw@mail.gmail.com>
From: Sjur Brændeland <sjurbren@gmail.com>
Date: Mon, 21 Nov 2011 22:20:09 +0100
>> The "tmp" variable here is used to store the result of cpu_to_le16()
>> so it should be an __le16 instead of an int. We want the high bits
>> set and the current code works on little endian systems but not on
>> big endian systems.
>>
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>> ---
>> v2: In v1 I used a u16 instead of an __le16. Also I've changed the
>> name to "data" instead of "tmp".
>
> Thanks Dan, good catch - this would have failed badly on a b_e architecture.
>
> Acked-by: Sjur Brændeland <sjur.brandeland@stericsson.com>
Applied, thanks guys.
next prev parent reply other threads:[~2011-11-21 21:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-21 6:17 [patch] caif: fix endian conversion in cffrml_transmit() Dan Carpenter
2011-11-21 6:33 ` Al Viro
2011-11-21 19:50 ` [patch v2] " Dan Carpenter
2011-11-21 21:20 ` Sjur Brændeland
2011-11-21 21:46 ` David Miller [this message]
2011-11-21 14:36 ` [patch] " Sjur BRENDELAND
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111121.164643.58544532996822474.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sjurbren@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).