Netdev List
 help / color / mirror / Atom feed
From: raj@tardy.cup.hp.com (Rick Jones)
To: <netdev@vger.kernel.org>, <rusty@rustcorp.com.au>, <mst@redhat.com>
Subject: [PATCH net-next] virtio_net: return already tracked tx_fifo_errors via virtnet_getstats()
Date: Mon, 21 Nov 2011 11:28:17 -0800 (PST)	[thread overview]
Message-ID: <20111121192817.F2CAE290041F@tardy> (raw)

From: Rick Jones <rick.jones2@hp.com>

Tx_fifo_errors are tracked in start_xmit_ for virtio_net, but not
reported in the tallies returned by virtnet_stats().  Return them
as the rx "sub-stats" rx_length_errors and rx_frame_errors are.

Signed-off-by: Rick Jones <rick.jones2@hp.com>

---

Compiled and booted in a guest, but no tx_fifo_errors generated.


diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index 4dc9d84..5a96172 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -700,6 +700,7 @@ static struct rtnl_link_stats64 *virtnet_stats(struct net_device *dev,
 	}
 
 	tot->tx_dropped = dev->stats.tx_dropped;
+	tot->tx_fifo_errors = dev->stats.tx_fifo_errors;
 	tot->rx_dropped = dev->stats.rx_dropped;
 	tot->rx_length_errors = dev->stats.rx_length_errors;
 	tot->rx_frame_errors = dev->stats.rx_frame_errors;

             reply	other threads:[~2011-11-21 19:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-21 19:28 Rick Jones [this message]
2011-11-22  0:56 ` [PATCH net-next] virtio_net: return already tracked tx_fifo_errors via virtnet_getstats() Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111121192817.F2CAE290041F@tardy \
    --to=raj@tardy.cup.hp.com \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox