From: Alexey Dobriyan <adobriyan@gmail.com>
To: David Laight <David.Laight@ACULAB.COM>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH] xfrm: optimize ipv4 selector matching
Date: Tue, 22 Nov 2011 18:41:32 +0300 [thread overview]
Message-ID: <20111122154132.GA25127@p183.telecom.by> (raw)
In-Reply-To: <AE90C24D6B3A694183C094C60CF0A2F6D8AED9@saturn3.aculab.com>
On Tue, Nov 22, 2011 at 03:15:25PM -0000, David Laight wrote:
>
> > Please use :
> >
> > +static inline bool addr4_match(__be32 a1, __be32 a2, u8 prefixlen)
> > +{
> > + /* C99 6.5.7 (3): u32 << 32 is undefined behaviour */
> > + if (prefixlen == 0)
> > + return true;
> > + return !((a1 ^ a2) & htonl(0xFFFFFFFFu << (32 - prefixlen)));
> > +}
>
> I'm not sure I'd agree about using 'u8'.
> It may well cause an unnecessary mask with 0xff.
It's u8 in all other places.
next prev parent reply other threads:[~2011-11-22 15:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-22 14:43 [PATCH] xfrm: optimize ipv4 selector matching Alexey Dobriyan
2011-11-22 14:50 ` David Laight
2011-11-22 14:59 ` Alexey Dobriyan
2011-11-22 15:10 ` Eric Dumazet
2011-11-22 15:15 ` David Laight
2011-11-22 15:41 ` Alexey Dobriyan [this message]
2011-11-22 16:46 ` [PATCH v2] " Alexey Dobriyan
2011-11-22 20:27 ` David Miller
2011-11-22 15:47 ` [PATCH] " Alexey Dobriyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111122154132.GA25127@p183.telecom.by \
--to=adobriyan@gmail.com \
--cc=David.Laight@ACULAB.COM \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox