From: David Miller <davem@davemloft.net>
To: shemminger@vyatta.com
Cc: therbert@google.com, netdev@vger.kernel.org
Subject: Re: [PATCH v3 03/10] net: Add netdev interfaces recording send/compl
Date: Wed, 23 Nov 2011 19:06:23 -0500 (EST) [thread overview]
Message-ID: <20111123.190623.2026426589805797580.davem@davemloft.net> (raw)
In-Reply-To: <20111123160320.76143e3b@nehalam.linuxnetplumber.net>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Wed, 23 Nov 2011 16:03:20 -0800
> On Wed, 23 Nov 2011 18:58:12 -0500 (EST)
> David Miller <davem@davemloft.net> wrote:
>
>> From: Stephen Hemminger <shemminger@vyatta.com>
>> Date: Wed, 23 Nov 2011 09:46:14 -0800
>>
>> > Since all the drivers that you show do this for one packet at a time,
>> > why bother with a packets arguement to netdev_sent_queue()?
>>
>> They batch the completion, that's why f.e. e1000e's changes keep track of
>> pkts_compl and bytes_compl, and then pass that in at the end of the TX
>> completion processing so that we only invoke these interfaces once per
>> run instead of once per packet.
>
> I was referring to the transmit routine, there for netdev_sent_queue()
> is always called with one packet.
Optimism for the future? :-)
But yeah if nobody batches right now, no reason to support this in the
interfaces, we can add it later.
next prev parent reply other threads:[~2011-11-24 0:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-23 5:52 [PATCH v3 03/10] net: Add netdev interfaces recording send/compl Tom Herbert
2011-11-23 17:46 ` Stephen Hemminger
2011-11-23 23:58 ` David Miller
2011-11-24 0:03 ` Stephen Hemminger
2011-11-24 0:06 ` David Miller [this message]
2011-11-24 0:32 ` Tom Herbert
2011-11-24 7:30 ` Dave Taht
2011-11-28 17:49 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111123.190623.2026426589805797580.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).