From: Dan Carpenter <dan.carpenter@oracle.com>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: walter harms <wharms@bfs.de>,
"David S. Miller" <davem@davemloft.net>,
linux-hams@vger.kernel.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] netrom: check that user string is terminated
Date: Wed, 23 Nov 2011 22:54:22 +0300 [thread overview]
Message-ID: <20111123195421.GB3258@mwanda> (raw)
In-Reply-To: <20111123191249.GB7260@linux-mips.org>
[-- Attachment #1: Type: text/plain, Size: 577 bytes --]
On Wed, Nov 23, 2011 at 07:12:49PM +0000, Ralf Baechle wrote:
> On Wed, Nov 23, 2011 at 09:22:16AM +0100, walter harms wrote:
>
> > I am not sure that it does what you intends.
> > mnemonic is an array and a malicious use may fill it upto the last char
> > causing strlen go beyond. perhaps this may help:
>
> Correct, it makes thigs worse. I'm going to reply in detail later tonight,
> have to bail out now.
>
Ok. I said in a different thread that I was going to redo these
using strnlen() but I'll wait to read your comments.
regards,
dan carpenter
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2011-11-23 19:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-23 6:52 [patch] netrom: check that user string is terminated Dan Carpenter
2011-11-23 8:22 ` walter harms
2011-11-23 19:12 ` Ralf Baechle
2011-11-23 19:54 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111123195421.GB3258@mwanda \
--to=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-hams@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=wharms@bfs.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).