Re: [PATCH net] net: Revert ARCNET and PHYLIB to tristate options

[David Miller <davem@davemloft.net>]

From: Ben Hutchings <ben@decadent.org.uk>
Date: Thu, 24 Nov 2011 07:23:30 +0000

> Commit 88491d8103498a6166f70d5999902fec70924314 ("drivers/net: Kconfig
> & Makefile cleanup") changed the type of these options to bool, but
> they select code that could (and still can) be built as modules.
> 
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> ---
> I consider the inability to build arcnet.o and libphy.o as modules to be
> a regression in 3.2 for general-purpose distribution kernels.
> Therefore, please apply this to the net tree.

I challenge you to get PHYLIB set to 'm' in a configuration such as
"allmodconfig" which is clearly in line with the kind of configuration
which "distribution kernels" use.

Did you really even try to see if it mattered?  Or did you just test
your change with a stripped down configuration you happened to have
readily available in some build tree?

I really consider this change entirely pointless, because for the
situation where you say it matters, it actually doesn't as far as I
can tell.

I'm therefore rejecting this patch.