Re: MACH_QQ2440 (and CS890x)

Re: MACH_QQ2440 (and CS890x)

[Domenico Andreoli]

Hi,

On Thu, Nov 24, 2011 at 10:17:35PM +0100, Paul Bolle wrote:
> 0) Since commit 2ce8c07d63 ("CS89x0: Add networking support for QQ2440")
> the mainline kernel tree uses the Kconfig symbol MACH_QQ2440 and the
> preprocessor macro CONFIG_MACH_QQ24400.

Yes, qq2440 got stuck at the beginning of the ongoing ARM arch
overhaul. I plan to submit it again when the situation settles a bit
and it will be more DT aware. In the meanwhile I'm working on a brand
new bcm4760 DT platform.

> 1) But there's currently no Kconfig entry for MACH_QQ2440. (Neither is
> there a direct definition of the macro CONFIG_MACH_QQ2440.) But a (stub)
> entry for MACH_QQ2440 was added to ARM's mach-types in commit 773e9610a7
> and removed again in commit 6f82f4db80 (which isn't too long after
> 2ce8c07d63).
> 
> 3) Are there any plans to add a Kconfig entry for MACH_QQ2440? If not,
> should I submit the (trivial) patch to drop that Kconfig symbol and that
> preprocessor macro?

The plan for qq2440 is to use the cs890x platform driver which is being
developed by Jaccon [0], maybe in the OF variant.  I already asked him
to remove these specific and unused macros for me.

So thank you for the offer but I hope the work of Jaccon will be
merged soon.

>
> Paul Bolle

cheers,
Domenico

[0] http://patchwork.ozlabs.org/patch/118623/

Re: MACH_QQ2440 (and CS890x)

[Paul Bolle]

(Canned message follows.)

On Fri, 2011-11-25 at 10:36 +0100, Domenico Andreoli wrote:
> On Thu, Nov 24, 2011 at 10:17:35PM +0100, Paul Bolle wrote:
> > 3) Are there any plans to add a Kconfig entry for MACH_QQ2440? If not,
> > should I submit the (trivial) patch to drop that Kconfig symbol and that
> > preprocessor macro?
> 
> The plan for qq2440 is to use the cs890x platform driver which is being
> developed by Jaccon [0], maybe in the OF variant.  I already asked him
> to remove these specific and unused macros for me.
> 
> So thank you for the offer but I hope the work of Jaccon will be
> merged soon.

Thanks. I'll stop worrying about this invalid Kconfig dependency for
now. It might pop up again if I ever decide to scan the mainline tree
for invalid symbols again. We'll see.


Paul Bolle

Re: MACH_QQ2440 (and CS890x)

[Domenico Andreoli]

On Fri, Nov 25, 2011 at 10:46:26AM +0100, Paul Bolle wrote:
> (Canned message follows.)
> 
> On Fri, 2011-11-25 at 10:36 +0100, Domenico Andreoli wrote:
> > On Thu, Nov 24, 2011 at 10:17:35PM +0100, Paul Bolle wrote:
> > > 3) Are there any plans to add a Kconfig entry for MACH_QQ2440? If not,
> > > should I submit the (trivial) patch to drop that Kconfig symbol and that
> > > preprocessor macro?
> > 
> > The plan for qq2440 is to use the cs890x platform driver which is being
> > developed by Jaccon [0], maybe in the OF variant.  I already asked him
> > to remove these specific and unused macros for me.
> > 
> > So thank you for the offer but I hope the work of Jaccon will be
> > merged soon.
> 
> Thanks. I'll stop worrying about this invalid Kconfig dependency for
> now. It might pop up again if I ever decide to scan the mainline tree
> for invalid symbols again. We'll see.

In such case I already ack the commit.

> Paul Bolle
Domenico