From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: himeraster@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] AF_UNIX: Fix poll locking problem when reading from a stream socket
Date: Sat, 26 Nov 2011 16:35:15 -0500 (EST) [thread overview]
Message-ID: <20111126.163515.1110138680165158231.davem@davemloft.net> (raw)
In-Reply-To: <1321939381.27077.7.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 22 Nov 2011 06:23:01 +0100
> Le mardi 22 novembre 2011 à 03:35 +0400, Alexey Moiseytsev a écrit :
>> poll() call may be locked by concurrent reading from the same stream
>> socket.
>>
>> Signed-off-by: Alexey Moiseytsev <himeraster@gmail.com>
..
> Fine, the fix is technically correct since we own u->readlock mutex,
> another thread cannot consume the just requeued skb.
>
> Small note : the words "locking" and "locked" are more used to describe
> the action of taking a spinlock/mutex/rwlock or something, while the bug
> you fixed is more about poll() system call being blocked/frozen forever.
>
> Thanks !
>
> Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied, with 'lock{ing,ed}' adjusted to 'block{ing,ed}'.
prev parent reply other threads:[~2011-11-26 21:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-21 23:35 [PATCH 1/1] AF_UNIX: Fix poll locking problem when reading from a stream socket Alexey Moiseytsev
2011-11-22 5:23 ` Eric Dumazet
2011-11-26 21:35 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111126.163515.1110138680165158231.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=himeraster@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).