netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: yanivr@broadcom.com
Cc: netdev@vger.kernel.org, eilong@broadcom.com
Subject: Re: [net-next 5/8] bnx2x: Change Warpcore MDIO work around mode
Date: Sun, 27 Nov 2011 17:03:45 -0500 (EST)	[thread overview]
Message-ID: <20111127.170345.210055753705612508.davem@davemloft.net> (raw)
In-Reply-To: <1322417881-17760-6-git-send-email-yanivr@broadcom.com>

From: "Yaniv Rosner" <yanivr@broadcom.com>
Date: Sun, 27 Nov 2011 20:17:58 +0200

> @@ -11308,7 +11308,9 @@ static int bnx2x_populate_int_phy(struct bnx2x *bp, u32 shmem_base, u8 port,
>  				       offsetof(struct shmem_region,
>  			dev_info.port_feature_config[port].link_config)) &
>  			  PORT_FEATURE_CONNECTED_SWITCH_MASK);
> -	chip_id = REG_RD(bp, MISC_REG_CHIP_NUM) << 16;
> +	chip_id = (REG_RD(bp, MISC_REG_CHIP_NUM) << 16) |
> +				((REG_RD(bp, MISC_REG_CHIP_REV) & 0xf) << 12);
> +

Bad formatting.

  reply	other threads:[~2011-11-27 22:03 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-27 18:17 [net-next 0/8] bnx2x: Link changes Yaniv Rosner
2011-11-27 18:17 ` [net-next 1/8] bnx2x: PFC changes Yaniv Rosner
2011-11-27 18:17 ` [net-next 2/8] bnx2x: ETS changes Yaniv Rosner
2011-11-27 22:02   ` David Miller
2011-11-27 18:17 ` [net-next 3/8] bnx2x: Warpcore-HW reset following fan failure Yaniv Rosner
2011-11-27 18:17 ` [net-next 4/8] bnx2x: Fix BCM84833 link and LED behavior Yaniv Rosner
2011-11-27 22:01   ` David Miller
2011-11-27 18:17 ` [net-next 5/8] bnx2x: Change Warpcore MDIO work around mode Yaniv Rosner
2011-11-27 22:03   ` David Miller [this message]
2011-11-27 18:17 ` [net-next 6/8] bnx2x: Add known PHY type check Yaniv Rosner
2011-11-27 22:01   ` David Miller
2011-11-27 18:18 ` [net-next 7/8] bnx2x: Fix self test of BCM57800 Yaniv Rosner
2011-11-27 22:03   ` David Miller
2011-11-27 18:18 ` [net-next 8/8] bnx2x: Cosmetic changes Yaniv Rosner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111127.170345.210055753705612508.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=eilong@broadcom.com \
    --cc=netdev@vger.kernel.org \
    --cc=yanivr@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).