netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: krkumar2@in.ibm.com, arnd@arndb.de, netdev@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	levinsasha928@gmail.com
Subject: Re: [PATCH] macvtap: Fix macvtap_get_queue to use rxhash first
Date: Sun, 27 Nov 2011 19:23:34 +0200	[thread overview]
Message-ID: <20111127172333.GD31987@redhat.com> (raw)
In-Reply-To: <20111125.013552.1613051198566054931.davem@davemloft.net>

On Fri, Nov 25, 2011 at 01:35:52AM -0500, David Miller wrote:
> From: Krishna Kumar2 <krkumar2@in.ibm.com>
> Date: Fri, 25 Nov 2011 09:39:11 +0530
> 
> > Jason Wang <jasowang@redhat.com> wrote on 11/25/2011 08:51:57 AM:
> >>
> >> My description is not clear again :(
> >> I mean the same vhost thead:
> >>
> >> vhost thread #0 transmits packets of flow A on processor M
> >> ...
> >> vhost thread #0 move to another process N and start to transmit packets
> >> of flow A
> > 
> > Thanks for clarifying. Yes, binding vhosts to CPU's
> > makes the incoming packet go to the same vhost each
> > time. BTW, are you doing any binding and/or irqbalance
> > when you run your tests? I am not running either at
> > this time, but thought both might be useful.
> 
> So are we going with this patch or are we saying that vhost binding
> is a requirement?

I think it's a good idea to make sure we understand the problem
root cause well before applying the patch. We still
have a bit of time before 3.2. In particular, why does
the vhost thread bounce between CPUs so much?

Long term it seems the best way is to expose the preferred mapping
from the guest and forward it to the device.

-- 
MST

  reply	other threads:[~2011-11-27 17:23 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-24  8:17 [PATCH] macvtap: Fix macvtap_get_queue to use rxhash first Krishna Kumar
2011-11-24  9:36 ` jasowang
2011-11-24  9:59 ` Michael S. Tsirkin
2011-11-24 10:13   ` jasowang
2011-11-24 10:34     ` Michael S. Tsirkin
2011-11-24 12:56       ` jasowang
2011-11-24 16:14         ` Michael S. Tsirkin
2011-11-25  3:07           ` Krishna Kumar2
2011-11-25  3:21             ` Jason Wang
2011-11-25  4:09               ` Krishna Kumar2
2011-11-25  6:35                 ` David Miller
2011-11-27 17:23                   ` Michael S. Tsirkin [this message]
2011-11-28  4:40                     ` Jason Wang
2011-12-07 16:10                   ` Michael S. Tsirkin
2011-12-07 18:52                     ` David Miller
2011-12-20 11:15                       ` Michael S. Tsirkin
2011-12-20 18:46                         ` David Miller
2011-12-08  9:46                     ` Jason Wang
2011-11-27 17:14                 ` Michael S. Tsirkin
2011-11-28  4:25                 ` Jason Wang
2011-11-28 17:42                   ` Stephen Hemminger
2011-11-25  3:09           ` Jason Wang
2011-11-24 11:14   ` Krishna Kumar2
2011-11-24 13:00     ` jasowang
2011-11-24 16:12       ` Michael S. Tsirkin
2011-11-25  2:58       ` Krishna Kumar2
2011-11-25  3:18         ` Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111127172333.GD31987@redhat.com \
    --to=mst@redhat.com \
    --cc=arnd@arndb.de \
    --cc=davem@davemloft.net \
    --cc=krkumar2@in.ibm.com \
    --cc=levinsasha928@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).