From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] net: Fix corruption in /proc/*/net/dev_mcast Date: Mon, 28 Nov 2011 18:08:07 -0500 (EST) Message-ID: <20111128.180807.649757269111867027.davem@davemloft.net> References: <1321870529.2552.19.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC> <20111128181446.2ab784d0@kryten> <1322474116.2292.5.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: anton@samba.org, levinsasha928@gmail.com, mpm@selenic.com, cl@linux-foundation.org, penberg@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, mihai.maruseac@gmail.com To: eric.dumazet@gmail.com Return-path: In-Reply-To: <1322474116.2292.5.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC> Sender: owner-linux-mm@kvack.org List-Id: netdev.vger.kernel.org From: Eric Dumazet Date: Mon, 28 Nov 2011 10:55:16 +0100 >> With slub debugging on I see red zone issues in /proc/*/net/dev_mcast: >> >> ============================================================================= >> BUG kmalloc-8: Redzone overwritten >> ----------------------------------------------------------------------------- ... >> dev_mc_seq_ops uses dev_seq_start/next/stop but only allocates >> sizeof(struct seq_net_private) of private data, whereas it expects >> sizeof(struct dev_iter_state): >> >> struct dev_iter_state { >> struct seq_net_private p; >> unsigned int pos; /* bucket << BUCKET_SPACE + offset */ >> }; >> >> Create dev_seq_open_ops and use it so we don't have to expose >> struct dev_iter_state. >> >> Signed-off-by: Anton Blanchard ... > Problem added by commit f04565ddf52e4 (dev: use name hash for > dev_seq_ops) > > > Acked-by: Eric Dumazet > CC: Mihai Maruseac Applied, thanks everyone. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org