From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next 4/4] sch_sfb: use skb_flow_dissect() Date: Mon, 28 Nov 2011 19:10:07 -0500 (EST) Message-ID: <20111128.191007.532525563961483504.davem@davemloft.net> References: <1322493902.2292.72.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: dev-yBygre7rU0TnMu66kgdUjQ@public.gmane.org, dan-BZ4SNL/Vixll57MIdRCFDg@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, fw-HFFVJYpyMKqzQB+pC5nmwQ@public.gmane.org, jhs-jkUAjuhPggJWk0Htik3J/w@public.gmane.org, john.r.fastabend-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, herbert-F6s6mLieUQo7FNHlEwC/lvQIK84fMopw@public.gmane.org, chrisw-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, shemminger-ZtmgI6mnKB3QT0dZR+AlfA@public.gmane.org To: eric.dumazet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org Return-path: In-Reply-To: <1322493902.2292.72.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dev-bounces-yBygre7rU0TnMu66kgdUjQ@public.gmane.org Errors-To: dev-bounces-yBygre7rU0TnMu66kgdUjQ@public.gmane.org List-Id: netdev.vger.kernel.org From: Eric Dumazet Date: Mon, 28 Nov 2011 16:25:02 +0100 > Current SFB double hashing is not fulfilling SFB theory, if two flows > share same rxhash value. > > Using skb_flow_dissect() permits to really have better hash dispersion, > and get tunnelling support as well. > > Double hashing point was mentioned by Florian Westphal > > Signed-off-by: Eric Dumazet Applied.