From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] flow_dissector: use a 64bit load/store
Date: Tue, 29 Nov 2011 13:23:10 -0500 (EST) [thread overview]
Message-ID: <20111129.132310.605559828840149508.davem@davemloft.net> (raw)
In-Reply-To: <1322548235.2970.57.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 29 Nov 2011 07:30:35 +0100
> [PATCH net-next] flow_dissector: use a 64bit load/store
>
> gcc compiler is smart enough to use a single load/store if we
> memcpy(dptr, sptr, 8) on x86_64, regardless of
> CONFIG_CC_OPTIMIZE_FOR_SIZE
>
> In IP header, daddr immediately follows saddr, this wont change in the
> future. We only need to make sure our flow_keys (src,dst) fields wont
> break the rule.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied.
next prev parent reply other threads:[~2011-11-29 18:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-28 15:22 [PATCH net-next 1/4] net: introduce skb_flow_dissect() Eric Dumazet
2011-11-28 16:25 ` Dimitris Michailidis
[not found] ` <4ED3B603.4010702-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
2011-11-29 0:06 ` David Miller
2011-11-29 6:30 ` [PATCH net-next] flow_dissector: use a 64bit load/store Eric Dumazet
2011-11-29 18:23 ` David Miller [this message]
2011-11-29 0:09 ` [PATCH net-next 1/4] net: introduce skb_flow_dissect() David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111129.132310.605559828840149508.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).