From: David Miller <davem@davemloft.net>
To: ulrich.weber@Sophos.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 2/3] route: set iif and oif information in flowi struct
Date: Tue, 29 Nov 2011 19:01:45 -0500 (EST) [thread overview]
Message-ID: <20111129.190145.548852258294275388.davem@davemloft.net> (raw)
In-Reply-To: <1322511292-1413-3-git-send-email-ulrich.weber@sophos.com>
From: Ulrich Weber <ulrich.weber@Sophos.com>
Date: Mon, 28 Nov 2011 21:14:51 +0100
> + }
> + else {
...
> + }
> + else {
Besides Julian's comments, these are not properly formatted, use:
} else {
instead.
next prev parent reply other threads:[~2011-11-30 0:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-28 20:14 [PATCH 0/3] xfrm: add incoming interface to selector Ulrich Weber
2011-11-28 20:14 ` [PATCH 1/3] " Ulrich Weber
2011-11-30 0:00 ` David Miller
2011-11-30 17:33 ` Ulrich Weber
2011-11-30 17:47 ` David Miller
2011-11-28 20:14 ` [PATCH 2/3] route: set iif and oif information in flowi struct Ulrich Weber
2011-11-28 23:53 ` Julian Anastasov
2011-11-30 17:21 ` Ulrich Weber
2011-11-30 22:37 ` Julian Anastasov
2011-11-30 0:01 ` David Miller [this message]
2011-11-28 20:14 ` [PATCH 3/3] xfrm: allow to overwrite incoming dev after decryption Ulrich Weber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111129.190145.548852258294275388.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=ulrich.weber@Sophos.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).