* [patch] batman-adv: remove extra negation in gw_out_of_range()
@ 2011-11-29 6:09 Dan Carpenter
[not found] ` <20111129060909.GA6098-mgFCXtclrQlZLf2FXnZxJA@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2011-11-29 6:09 UTC (permalink / raw)
To: Marek Lindner
Cc: Simon Wunderlich, David S. Miller, b.a.t.m.a.n, netdev,
kernel-janitors
There is a typo here where an extra '!' made the check to the opposite
of what was intended.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/net/batman-adv/gateway_client.c b/net/batman-adv/gateway_client.c
index 9373a14..24403a7 100644
--- a/net/batman-adv/gateway_client.c
+++ b/net/batman-adv/gateway_client.c
@@ -695,7 +695,7 @@ bool gw_out_of_range(struct bat_priv *bat_priv,
}
neigh_old = find_router(bat_priv, orig_dst_node, NULL);
- if (!!neigh_old)
+ if (!neigh_old)
goto out;
if (curr_tq_avg - neigh_old->tq_avg > GW_THRESHOLD)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] batman-adv: remove extra negation in gw_out_of_range()
[not found] ` <20111129060909.GA6098-mgFCXtclrQlZLf2FXnZxJA@public.gmane.org>
@ 2011-11-29 6:41 ` Marek Lindner
0 siblings, 0 replies; 2+ messages in thread
From: Marek Lindner @ 2011-11-29 6:41 UTC (permalink / raw)
To: b.a.t.m.a.n-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r
Cc: netdev-u79uwXL29TY76Z2rM5mHXA, Simon Wunderlich,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA, David S. Miller,
Dan Carpenter
On Tuesday, November 29, 2011 14:09:09 Dan Carpenter wrote:
> There is a typo here where an extra '!' made the check to the opposite
> of what was intended.
>
> Signed-off-by: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
>
> diff --git a/net/batman-adv/gateway_client.c
> b/net/batman-adv/gateway_client.c index 9373a14..24403a7 100644
> --- a/net/batman-adv/gateway_client.c
> +++ b/net/batman-adv/gateway_client.c
> @@ -695,7 +695,7 @@ bool gw_out_of_range(struct bat_priv *bat_priv,
> }
>
> neigh_old = find_router(bat_priv, orig_dst_node, NULL);
> - if (!!neigh_old)
> + if (!neigh_old)
> goto out;
>
> if (curr_tq_avg - neigh_old->tq_avg > GW_THRESHOLD)
Wow - you are right! Applied in our tree.
Thanks,
Marek
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-11-29 6:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-29 6:09 [patch] batman-adv: remove extra negation in gw_out_of_range() Dan Carpenter
[not found] ` <20111129060909.GA6098-mgFCXtclrQlZLf2FXnZxJA@public.gmane.org>
2011-11-29 6:41 ` Marek Lindner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).