From: Stephen Hemminger <shemminger@vyatta.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Miller <davem@davemloft.net>,
ycheng@google.com, rick.jones2@hp.com, netdev@vger.kernel.org
Subject: Re: is non-inheritance of congestion control algorithm from the listen socket a bug or a feature?
Date: Tue, 29 Nov 2011 14:01:58 -0800 [thread overview]
Message-ID: <20111129140158.352ea90b@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <1322603786.2596.36.camel@edumazet-laptop>
On Tue, 29 Nov 2011 22:56:26 +0100
Eric Dumazet <eric.dumazet@gmail.com> wrote:
> Le mardi 29 novembre 2011 à 16:52 -0500, David Miller a écrit :
>
> > There is really no reason to keep the current behavior.
> >
> > If an application sets the congestion control algorithm on a listening
> > socket to a non-default value, what effect could possibly be intended?
> >
> > Congestion control doesn't even come into play at all on a listening
> > socket, therefore the only logical expectation is that it inherits to
> > the child.
> >
> > The only other logical behavior would be to forbid this operation on a
> > listening socket, since it has no effect, but that doesn't make any
> > sense now does it? :-)
>
> Moreover, an application can use setsockopt(TCP_CONGESTION) before
> calling listen() (while socket is still in CLOSE state)
Agreed, it was just an oversight of the initial design.
The setsockopt() on the listening socket is ignored.
prev parent reply other threads:[~2011-11-29 22:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-29 20:03 is non-inheritance of congestion control algorithm from the listen socket a bug or a feature? Rick Jones
2011-11-29 20:27 ` Dave Taht
2011-11-29 20:56 ` Eric Dumazet
2011-11-29 21:17 ` Rick Jones
2011-11-29 21:20 ` Yuchung Cheng
2011-11-29 21:46 ` Eric Dumazet
2011-11-29 21:52 ` David Miller
2011-11-29 21:56 ` Eric Dumazet
2011-11-29 22:01 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111129140158.352ea90b@nehalam.linuxnetplumber.net \
--to=shemminger@vyatta.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=rick.jones2@hp.com \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).