From: David Miller <davem@davemloft.net>
To: sjur.brandeland@stericsson.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next 3/3] caif: Remove unused enum and parameter in cfserl
Date: Wed, 30 Nov 2011 17:04:57 -0500 (EST) [thread overview]
Message-ID: <20111130.170457.1002117290486935116.davem@davemloft.net> (raw)
In-Reply-To: <1322680968-6470-3-git-send-email-sjur.brandeland@stericsson.com>
From: Sjur Brændeland <sjur.brandeland@stericsson.com>
Date: Wed, 30 Nov 2011 20:22:48 +0100
> link_support = cfserl_create(dev->ifindex,
> - CFPHYTYPE_FRAG, caifdev->use_stx);
> + caifdev->use_stx);
> if (!link_support) {
> pr_warn("Out of memory\n");
> break;
...
> -struct cflayer *cfserl_create(int type, int instance, bool use_stx)
> +struct cflayer *cfserl_create(int instance, bool use_stx)
> {
Looks like this code was always buggy, passing the index in the type parameter
and the type in the instance parameter.
next prev parent reply other threads:[~2011-11-30 22:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-30 19:22 [PATCH net-next 1/3] caif: Allow cfpkt_extr_head to process empty message Sjur Brændeland
2011-11-30 19:22 ` [PATCH net-next 2/3] caif: Restructure how link caif link layer enroll Sjur Brændeland
2011-12-01 4:38 ` David Miller
2011-11-30 19:22 ` [PATCH net-next 3/3] caif: Remove unused enum and parameter in cfserl Sjur Brændeland
2011-11-30 22:04 ` David Miller [this message]
2011-11-30 23:02 ` [PATCH] caif: Remove unused attributes from struct cflayer Sjur Brændeland
2011-12-01 4:38 ` David Miller
2011-12-01 4:38 ` [PATCH net-next 3/3] caif: Remove unused enum and parameter in cfserl David Miller
2011-12-01 4:37 ` [PATCH net-next 1/3] caif: Allow cfpkt_extr_head to process empty message David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111130.170457.1002117290486935116.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=sjur.brandeland@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).