From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: therbert@google.com, jesse.brandeburg@intel.com, netdev@vger.kernel.org
Subject: Re: [PATCH v4 06/10] e1000e: Support for byte queue limits
Date: Thu, 01 Dec 2011 12:48:58 -0500 (EST) [thread overview]
Message-ID: <20111201.124858.1240854874296338456.davem@davemloft.net> (raw)
In-Reply-To: <1322734334.2335.20.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 01 Dec 2011 11:12:14 +0100
> OK, as stated on your other thread, its obvious this driver (and
> probably other intel drivers) made assumptions that are now obsolete,
> since skb head can contain some data payload, not only (MAC+IP+TCP)
> headers.
They were always wrong assumptions even before your patch Eric.
Any Netfilter or similar module can pull some data into the linear
area before the driver sees the packet on transmit.
prev parent reply other threads:[~2011-12-01 17:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-29 2:33 [PATCH v4 06/10] e1000e: Support for byte queue limits Tom Herbert
2011-11-29 21:01 ` Jesse Brandeburg
2011-12-01 1:04 ` Tom Herbert
2011-12-01 10:12 ` Eric Dumazet
2011-12-01 16:32 ` Tom Herbert
2011-12-01 16:40 ` Eric Dumazet
2011-12-01 17:48 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111201.124858.1240854874296338456.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=jesse.brandeburg@intel.com \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).