From: David Miller <davem@davemloft.net>
To: panweiping3@gmail.com
Cc: kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org,
kaber@trash.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] ipv4: flush route cache after change accept_local
Date: Thu, 01 Dec 2011 12:52:00 -0500 (EST) [thread overview]
Message-ID: <20111201.125200.1219939487021672308.davem@davemloft.net> (raw)
In-Reply-To: <1e224b52de77dcd5f994c8e4c77c780c6996e4a4.1322740026.git.panweiping3@gmail.com>
From: Weiping Pan <panweiping3@gmail.com>
Date: Thu, 1 Dec 2011 19:47:56 +0800
> + if ((i == IPV4_DEVCONF_ACCEPT_LOCAL - 1))
I don't think the extra parenthesis is appropriate here, please only use
one set of them.
Thanks.
next prev parent reply other threads:[~2011-12-01 17:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-01 11:47 [PATCH net] ipv4: flush route cache after change accept_local Weiping Pan
2011-12-01 17:52 ` David Miller [this message]
2011-12-02 1:47 ` [PATCH] " Weiping Pan
2011-12-02 2:46 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111201.125200.1219939487021672308.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=panweiping3@gmail.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).