From: David Miller <davem@davemloft.net>
To: shemminger@vyatta.com
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org
Subject: Re: [PATCH] bridge: master device stuck in no-carrier state forever when in user-stp mode
Date: Thu, 01 Dec 2011 14:05:48 -0500 (EST) [thread overview]
Message-ID: <20111201.140548.1596323918646956109.davem@davemloft.net> (raw)
In-Reply-To: <20111201104409.2d04ca06@nehalam.linuxnetplumber.net>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Thu, 1 Dec 2011 10:44:09 -0800
> On Fri, 25 Nov 2011 12:16:37 +0200
> Vitalii Demianets <vitas@nppfactor.kiev.ua> wrote:
>
>> When in user-stp mode, bridge master do not follow state of its slaves, so
>> after the following sequence of events it can stuck forever in no-carrier
>> state:
>> 1) turn stp off
>> 2) put all slaves down - master device will follow their state and also go in
>> no-carrier state
>> 3) turn stp on with bridge-stp script returning 0 (go to the user-stp mode)
>> Now bridge master won't follow slaves' state and will never reach running
>> state.
>>
>> This patch solves the problem by making user-stp and kernel-stp behavior
>> similar regarding master following slaves' states.
>>
>> Signed-off-by: Vitalii Demianets <vitas@nppfactor.kiev.ua>
>
> This method works fine. David please apply to -net.
>
> Acked-by: Stephen Hemminger <shemminger@vyatta.com>
Done.
prev parent reply other threads:[~2011-12-01 19:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-25 10:16 [PATCH] bridge: master device stuck in no-carrier state forever when in user-stp mode Vitalii Demianets
2011-11-29 23:54 ` David Miller
2011-11-30 0:06 ` Stephen Hemminger
2011-12-01 18:44 ` Stephen Hemminger
2011-12-01 19:05 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111201.140548.1596323918646956109.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bridge@lists.linux-foundation.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).