* [PATCH net] ipv4: flush route cache after change accept_local
@ 2011-12-01 11:47 Weiping Pan
2011-12-01 17:52 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Weiping Pan @ 2011-12-01 11:47 UTC (permalink / raw)
Cc: Weiping Pan, David S. Miller, Alexey Kuznetsov, James Morris,
Hideaki YOSHIFUJI, Patrick McHardy,
open list:NETWORKING [IPv4/..., open list
After reset ipv4_devconf->data[IPV4_DEVCONF_ACCEPT_LOCAL] to 0,
we should flash route cache, or it will continue receive packets with local
source address, which should be dropped.
Signed-off-by: Weiping Pan <panweiping3@gmail.com>
---
net/ipv4/devinet.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c
index c6b5092..de1a772 100644
--- a/net/ipv4/devinet.c
+++ b/net/ipv4/devinet.c
@@ -1490,7 +1490,9 @@ static int devinet_conf_proc(ctl_table *ctl, int write,
void __user *buffer,
size_t *lenp, loff_t *ppos)
{
+ int old_value = *(int *)ctl->data;
int ret = proc_dointvec(ctl, write, buffer, lenp, ppos);
+ int new_value = *(int *)ctl->data;
if (write) {
struct ipv4_devconf *cnf = ctl->extra1;
@@ -1501,6 +1503,9 @@ static int devinet_conf_proc(ctl_table *ctl, int write,
if (cnf == net->ipv4.devconf_dflt)
devinet_copy_dflt_conf(net, i);
+ if ((i == IPV4_DEVCONF_ACCEPT_LOCAL - 1))
+ if ((new_value == 0) && (old_value != 0))
+ rt_cache_flush(net, 0);
}
return ret;
--
1.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH net] ipv4: flush route cache after change accept_local
2011-12-01 11:47 [PATCH net] ipv4: flush route cache after change accept_local Weiping Pan
@ 2011-12-01 17:52 ` David Miller
2011-12-02 1:47 ` [PATCH] " Weiping Pan
0 siblings, 1 reply; 4+ messages in thread
From: David Miller @ 2011-12-01 17:52 UTC (permalink / raw)
To: panweiping3; +Cc: kuznet, jmorris, yoshfuji, kaber, netdev, linux-kernel
From: Weiping Pan <panweiping3@gmail.com>
Date: Thu, 1 Dec 2011 19:47:56 +0800
> + if ((i == IPV4_DEVCONF_ACCEPT_LOCAL - 1))
I don't think the extra parenthesis is appropriate here, please only use
one set of them.
Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ipv4: flush route cache after change accept_local
2011-12-01 17:52 ` David Miller
@ 2011-12-02 1:47 ` Weiping Pan
2011-12-02 2:46 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Weiping Pan @ 2011-12-02 1:47 UTC (permalink / raw)
Cc: Weiping Pan, David S. Miller, Alexey Kuznetsov, James Morris,
Hideaki YOSHIFUJI, Patrick McHardy,
open list:NETWORKING [IPv4/..., open list
After reset ipv4_devconf->data[IPV4_DEVCONF_ACCEPT_LOCAL] to 0,
we should flush route cache, or it will continue receive packets with local
source address, which should be dropped.
Signed-off-by: Weiping Pan <panweiping3@gmail.com>
---
net/ipv4/devinet.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c
index c6b5092..65f01dc 100644
--- a/net/ipv4/devinet.c
+++ b/net/ipv4/devinet.c
@@ -1490,7 +1490,9 @@ static int devinet_conf_proc(ctl_table *ctl, int write,
void __user *buffer,
size_t *lenp, loff_t *ppos)
{
+ int old_value = *(int *)ctl->data;
int ret = proc_dointvec(ctl, write, buffer, lenp, ppos);
+ int new_value = *(int *)ctl->data;
if (write) {
struct ipv4_devconf *cnf = ctl->extra1;
@@ -1501,6 +1503,9 @@ static int devinet_conf_proc(ctl_table *ctl, int write,
if (cnf == net->ipv4.devconf_dflt)
devinet_copy_dflt_conf(net, i);
+ if (i == IPV4_DEVCONF_ACCEPT_LOCAL - 1)
+ if ((new_value == 0) && (old_value != 0))
+ rt_cache_flush(net, 0);
}
return ret;
--
1.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] ipv4: flush route cache after change accept_local
2011-12-02 1:47 ` [PATCH] " Weiping Pan
@ 2011-12-02 2:46 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2011-12-02 2:46 UTC (permalink / raw)
To: panweiping3; +Cc: kuznet, jmorris, yoshfuji, kaber, netdev, linux-kernel
From: Weiping Pan <panweiping3@gmail.com>
Date: Fri, 2 Dec 2011 09:47:06 +0800
> After reset ipv4_devconf->data[IPV4_DEVCONF_ACCEPT_LOCAL] to 0,
> we should flush route cache, or it will continue receive packets with local
> source address, which should be dropped.
>
> Signed-off-by: Weiping Pan <panweiping3@gmail.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-12-02 2:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-01 11:47 [PATCH net] ipv4: flush route cache after change accept_local Weiping Pan
2011-12-01 17:52 ` David Miller
2011-12-02 1:47 ` [PATCH] " Weiping Pan
2011-12-02 2:46 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).