From: David Miller <davem@davemloft.net>
To: sjur.brandeland@stericsson.com
Cc: netdev@vger.kernel.org, alexey.orishko@stericsson.com,
eric.dumazet@gmail.com
Subject: Re: [PATCHv2 net-next 2/4] caif: Add support for CAIF over CDC NCM USB interface
Date: Sun, 04 Dec 2011 13:18:36 -0500 (EST) [thread overview]
Message-ID: <20111204.131836.231887333540568891.davem@davemloft.net> (raw)
In-Reply-To: <1322993450-8802-3-git-send-email-sjur.brandeland@stericsson.com>
From: Sjur Brændeland <sjur.brandeland@stericsson.com>
Date: Sun, 4 Dec 2011 11:10:48 +0100
> NCM 1.0 does not support anything but Ethernet framing, hence
> CAIF payload will be put into Ethernet frames.
>
> Discovery is based on fixed USB vendor 0x04cc (ST-Ericsson),
> product-id 0x230f (NCM). In this variant only CAIF payload is sent over
> the NCM interface.
>
> The CAIF stack (cfusbl.c) will when USB interface register first check if
> we got a CDC NCM USB interface with the right VID, PID.
> It will then read the device's Ethernet address and create a 'template'
> Ethernet TX header, using a broadcast address as the destination address,
> and EthType 0x88b5 (802.1 Local Experimental - vendor specific).
>
> A protocol handler for 0x88b5 is setup for reception of CAIF frames from
> the CDC NCM USB interface.
>
> Signed-off-by: Sjur Brændeland <sjur.brandeland@stericsson.com>
Please make this feature a tristate and make the init and exit
routines executed via the normal modula_init()/module_exit()
mechanisms.
That way you don't need that dopey header file to export the
init and exit routines, and you don't need to ifdef crap up the
code CAIF code to invoke them.
next prev parent reply other threads:[~2011-12-04 18:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-04 10:10 [PATCHv2 net-next 0/4] caif: CAIF for CDC NCM USB Sjur Brændeland
2011-12-04 10:10 ` [PATCHv2 net-next 1/4] if_ether.h: Add IEEE 802.1 Local Experimental Ethertype 1 Sjur Brændeland
2011-12-04 10:10 ` [PATCHv2 net-next 2/4] caif: Add support for CAIF over CDC NCM USB interface Sjur Brændeland
2011-12-04 18:18 ` David Miller [this message]
2011-12-04 10:10 ` [PATCHv2 net-next 3/4] caif: Add support for flow-control on device's tx-queue Sjur Brændeland
2011-12-04 10:10 ` [PATCHv2 net-next 4/4] caif: Stash away hijacked skb destructor and call it later Sjur Brændeland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111204.131836.231887333540568891.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexey.orishko@stericsson.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sjur.brandeland@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).