From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: CIFS mount: 3.2.0-rc3 suspend crash Date: Mon, 5 Dec 2011 09:41:26 -0800 Message-ID: <20111205174126.GF627@google.com> References: <4ED56C12.1040708@gmail.com> <4ED5C047.6040500@linux.vnet.ibm.com> <20111130062502.68d9db59@tlielax.poochiereds.net> <4ED81077.2080305@gmail.com> <4ED8C940.20509@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Woody Suwalski , Jeff Layton , LKML , "Rafael J. Wysocki" , Linux PM mailing list , Belisko Marek , linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Network Development , Greg Kroah-Hartman , davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org To: "Srivatsa S. Bhat" Return-path: Content-Disposition: inline In-Reply-To: <4ED8C940.20509-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org> Sender: linux-cifs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org Hello, Srivatsa. On Fri, Dec 02, 2011 at 06:19:04PM +0530, Srivatsa S. Bhat wrote: > So how about solving this problem more fundamentally, such as defining a > freezable wrapper over kernel_recvmsg like: > > #define kernel_recvmsg_freezable(sock, msg, vec, num, size, flags) \ > ({ \ > kernel_recvmsg(sock, msg, vec, num, size, flags) \ > try_to_freeze(); \ > }) > > and using it instead of kernel_recvmsg(), throughout the kernel? > > But kernel_recvmsg is an exported symbol. So if we are very very unwilling > to change the kernel ABI, we could probably think about adding try_to_freeze() > inside kernel_recvmsg itself,like this (but see below about my thoughts about > which one is better): I don't necessarily object to introducing the wrapper but I don't really think we should be doing s//g over the source tree without understanding where it's actually necessary. For kernel threads and user threads out of the signal delivery path, try_to_freeze() is an exceptional event which introduces behavior which can be difficult to reproduce track down and spreading it without actually knowing what the surrounding code is doing doesn't sound like a good idea to me. Thank you. -- tejun