From: David Miller <davem@davemloft.net>
To: mchan@broadcom.com
Cc: netdev@vger.kernel.org, barak@broadcom.com, eilong@broadcom.com
Subject: Re: [PATCH net-next 3/4] bnx2x: support classification config query
Date: Tue, 06 Dec 2011 00:46:29 -0500 (EST) [thread overview]
Message-ID: <20111206.004629.1477080329086805790.davem@davemloft.net> (raw)
In-Reply-To: <1323150288-28153-3-git-send-email-mchan@broadcom.com>
From: "Michael Chan" <mchan@broadcom.com>
Date: Mon, 5 Dec 2011 21:44:47 -0800
> + /* traverse list */
> + list_for_each_entry(pos, &o->head, link)
> + {
Put openning "{" at end of list_for_each_entry(), rather than
on a new line.
> + if ((counter < n)) {
Excessive parenthesis, remove.
> + memcpy(next + MAC_LEADING_ZERO_CNT,
> + pos->u.mac.mac, ETH_ALEN);
Paremeters on subsequent lines don't line up properly.
> + next = buf + counter * ALIGN(ETH_ALEN,
> + sizeof(u32));
Likewise.
> + DP(BNX2X_MSG_SP, "copied element number "
> + "%d to address %p element was "
> + "%pM\n", counter, next, pos->u.mac.mac);
Likewise.
> + int (*get_n_elements)(struct bnx2x *bp,
> + struct bnx2x_vlan_mac_obj *o,
> + int n,
> + u8 *buf);
> +
Likewise.
Sigh.
Definitely a new-comer wrote this code, but I know more experienced hands
reviewed it, therefore I am disappointed.
next prev parent reply other threads:[~2011-12-06 5:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-06 5:44 [PATCH net-next 1/4] bnx2x: add PFC statistics Michael Chan
2011-12-06 5:44 ` [PATCH net-next 2/4] bnx2x: add fcoe statistics Michael Chan
2011-12-06 5:44 ` [PATCH net-next 3/4] bnx2x: support classification config query Michael Chan
2011-12-06 5:44 ` [PATCH net-next 4/4] bnx2x, cnic: support DRV_INFO upon FW request Michael Chan
2011-12-06 5:56 ` Joe Perches
2011-12-06 5:46 ` David Miller [this message]
2011-12-06 5:57 ` [PATCH net-next 3/4] bnx2x: support classification config query Michael Chan
2011-12-06 5:59 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111206.004629.1477080329086805790.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=barak@broadcom.com \
--cc=eilong@broadcom.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).