* [PATCH] netback: remove redundant assignment
@ 2011-12-06 10:08 Wei Liu
2011-12-06 10:21 ` Ian Campbell
0 siblings, 1 reply; 3+ messages in thread
From: Wei Liu @ 2011-12-06 10:08 UTC (permalink / raw)
To: xen-devel, netdev; +Cc: ian.campbell, Wei Liu
New value for netbk->mmap_pages[pending_idx] is assigned in
xen_netbk_alloc_page(), no need for a second assignment which
exposes internal to the outside world.
Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
drivers/net/xen-netback/netback.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c
index 15e332d..3ecb5aa 100644
--- a/drivers/net/xen-netback/netback.c
+++ b/drivers/net/xen-netback/netback.c
@@ -940,8 +940,6 @@ static struct gnttab_copy *xen_netbk_get_requests(struct xen_netbk *netbk,
if (!page)
return NULL;
- netbk->mmap_pages[pending_idx] = page;
-
gop->source.u.ref = txp->gref;
gop->source.domid = vif->domid;
gop->source.offset = txp->offset;
@@ -1336,8 +1334,6 @@ static unsigned xen_netbk_tx_build_gops(struct xen_netbk *netbk)
continue;
}
- netbk->mmap_pages[pending_idx] = page;
-
gop->source.u.ref = txreq.gref;
gop->source.domid = vif->domid;
gop->source.offset = txreq.offset;
--
1.7.2.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] netback: remove redundant assignment
2011-12-06 10:08 [PATCH] netback: remove redundant assignment Wei Liu
@ 2011-12-06 10:21 ` Ian Campbell
2011-12-06 18:14 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Ian Campbell @ 2011-12-06 10:21 UTC (permalink / raw)
To: Wei Liu; +Cc: xen-devel@lists.xensource.com, netdev@vger.kernel.org
On Tue, 2011-12-06 at 10:08 +0000, Wei Liu wrote:
> New value for netbk->mmap_pages[pending_idx] is assigned in
> xen_netbk_alloc_page(), no need for a second assignment which
> exposes internal to the outside world.
>
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
> ---
> drivers/net/xen-netback/netback.c | 4 ----
> 1 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c
> index 15e332d..3ecb5aa 100644
> --- a/drivers/net/xen-netback/netback.c
> +++ b/drivers/net/xen-netback/netback.c
> @@ -940,8 +940,6 @@ static struct gnttab_copy *xen_netbk_get_requests(struct xen_netbk *netbk,
> if (!page)
> return NULL;
>
> - netbk->mmap_pages[pending_idx] = page;
> -
> gop->source.u.ref = txp->gref;
> gop->source.domid = vif->domid;
> gop->source.offset = txp->offset;
> @@ -1336,8 +1334,6 @@ static unsigned xen_netbk_tx_build_gops(struct xen_netbk *netbk)
> continue;
> }
>
> - netbk->mmap_pages[pending_idx] = page;
> -
> gop->source.u.ref = txreq.gref;
> gop->source.domid = vif->domid;
> gop->source.offset = txreq.offset;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] netback: remove redundant assignment
2011-12-06 10:21 ` Ian Campbell
@ 2011-12-06 18:14 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2011-12-06 18:14 UTC (permalink / raw)
To: Ian.Campbell; +Cc: wei.liu2, xen-devel, netdev
From: Ian Campbell <Ian.Campbell@citrix.com>
Date: Tue, 6 Dec 2011 10:21:22 +0000
> On Tue, 2011-12-06 at 10:08 +0000, Wei Liu wrote:
>> New value for netbk->mmap_pages[pending_idx] is assigned in
>> xen_netbk_alloc_page(), no need for a second assignment which
>> exposes internal to the outside world.
>>
>> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
Applied to net-next, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-12-06 18:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-06 10:08 [PATCH] netback: remove redundant assignment Wei Liu
2011-12-06 10:21 ` Ian Campbell
2011-12-06 18:14 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).