From: David Miller <davem@davemloft.net>
To: shawn.guo@linaro.org
Cc: netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] net/fec: fix the use of pdev->id
Date: Wed, 07 Dec 2011 13:38:33 -0500 (EST) [thread overview]
Message-ID: <20111207.133833.1526414845107847968.davem@davemloft.net> (raw)
In-Reply-To: <1323097275-7846-1-git-send-email-shawn.guo@linaro.org>
From: Shawn Guo <shawn.guo@linaro.org>
Date: Mon, 5 Dec 2011 23:01:15 +0800
> The pdev->id is used in several places for different purpose. All
> these uses assume it's always the id of fec device which is >= 0.
> However this is only true for non-DT case. When DT plays, pdev->id
> is always -1, which will break these pdev->id users.
>
> Instead of fixing all these users one by one, this patch introduces
> a new member 'dev_id' to 'struct fec_enet_private' for holding the
> correct fec device id, and replaces all the existing uses of pdev->id
> with this dev_id.
>
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Applied.
prev parent reply other threads:[~2011-12-07 18:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-05 15:01 [PATCH] net/fec: fix the use of pdev->id Shawn Guo
2011-12-07 18:38 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111207.133833.1526414845107847968.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).