From: David Miller <davem@davemloft.net>
To: joe@perches.com
Cc: ajit.khaparde@Emulex.Com, netdev@vger.kernel.org
Subject: Re: [net-next PATCH 2/2] be2net: workaround to fix a BE bug
Date: Thu, 08 Dec 2011 00:09:47 -0500 (EST) [thread overview]
Message-ID: <20111208.000947.193581253177810925.davem@davemloft.net> (raw)
In-Reply-To: <1323320840.1762.61.camel@joe2Laptop>
From: Joe Perches <joe@perches.com>
Date: Wed, 07 Dec 2011 21:07:20 -0800
> On Thu, 2011-12-08 at 00:00 -0500, David Miller wrote:
>> From: Ajit Khaparde <ajit.khaparde@Emulex.Com>
>> > + if (unlikely(vlan_tx_tag_present(skb) &&
>> > + (skb->ip_summed != CHECKSUM_PARTIAL || skb->len <= 60))) {
>> Poorly formatted, the second line opening first non-space character
>> needs to line up precisely after the first column after the if() statements
>> opening parenthesis.
>
> In this case I believe you mean after the unlikely(
>
> if (unlikely(vlan_tx_tag_present(skb) &&
> (skb->ip_summed != CHECKSUM_PARTIAL || skb->len <= 60))) {
Right.
prev parent reply other threads:[~2011-12-08 5:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-07 23:44 [net-next PATCH 2/2] be2net: workaround to fix a BE bug Ajit Khaparde
2011-12-08 5:00 ` David Miller
2011-12-08 5:07 ` Joe Perches
2011-12-08 5:09 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111208.000947.193581253177810925.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ajit.khaparde@Emulex.Com \
--cc=joe@perches.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).