From: David Miller <davem@davemloft.net>
To: bcrl@kvack.org
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] add netpoll support for 802.1q vlans
Date: Thu, 08 Dec 2011 11:50:55 -0500 (EST) [thread overview]
Message-ID: <20111208.115055.193423469660678623.davem@davemloft.net> (raw)
In-Reply-To: <20111208153558.GE30652@kvack.org>
From: Benjamin LaHaise <bcrl@kvack.org>
Date: Thu, 8 Dec 2011 10:35:58 -0500
> On Thu, Dec 08, 2011 at 12:07:30AM -0500, David Miller wrote:
>> From: Benjamin LaHaise <bcrl@kvack.org>
>> Date: Tue, 6 Dec 2011 20:04:24 -0500
>>
>> > Add netpoll support to 802.1q vlan devices. Based on the netpoll support
>> > in the bridging code. Tested on a forced_eth device with netconsole.
>> >
>> > Signed-off-by: Benjamin LaHaise <bcrl@kvack.org>
>>
>> Bridging doesn't try to invoke a downstream netpoll operation at all,
>> and neither should you.
>
> Please have a look at net/bridge/br_device.c:br_netpoll_setup() which is
> where the approach came from.
I did and I'm not talking about that part, I'm talking about the
part where you invoke the downstream device's netpoll operation.
Did you even read my entire sentence, or did you just let the
knee jerk reaction set in before you got to the end?
> Getting netconsole over vlans working is a requirement for those of us
What does this have to do with anything? I never made any even remote
argument that this change wasn't useful. I said only that you
implemented it incorrectly.
Take a deep breath and just implement the patch correctly.
next prev parent reply other threads:[~2011-12-08 16:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-07 1:04 [PATCH] add netpoll support for 802.1q vlans Benjamin LaHaise
2011-12-08 5:07 ` David Miller
2011-12-08 15:35 ` Benjamin LaHaise
2011-12-08 16:20 ` [PATCH net-next v2] vlan: add 802.1q netpoll support Benjamin LaHaise
2011-12-09 0:55 ` David Miller
2011-12-08 16:50 ` David Miller [this message]
2011-12-08 9:14 ` [PATCH] add netpoll support for 802.1q vlans WANG Cong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111208.115055.193423469660678623.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bcrl@kvack.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).