* [patch] sock_diag: off by one checks
@ 2011-12-08 6:49 Dan Carpenter
2011-12-08 9:07 ` Pavel Emelyanov
2011-12-09 0:54 ` David Miller
0 siblings, 2 replies; 4+ messages in thread
From: Dan Carpenter @ 2011-12-08 6:49 UTC (permalink / raw)
To: David S. Miller; +Cc: Pavel Emelyanov, netdev, kernel-janitors
These tests are off by one because sock_diag_handlers[] only has AF_MAX
elements.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/net/core/sock_diag.c b/net/core/sock_diag.c
index fbaf01c..9c27bcd 100644
--- a/net/core/sock_diag.c
+++ b/net/core/sock_diag.c
@@ -32,7 +32,7 @@ int sock_diag_register(struct sock_diag_handler *hndl)
{
int err = 0;
- if (hndl->family > AF_MAX)
+ if (hndl->family >= AF_MAX)
return -EINVAL;
mutex_lock(&sock_diag_table_mutex);
@@ -50,7 +50,7 @@ void sock_diag_unregister(struct sock_diag_handler *hnld)
{
int family = hnld->family;
- if (family > AF_MAX)
+ if (family >= AF_MAX)
return;
mutex_lock(&sock_diag_table_mutex);
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [patch] sock_diag: off by one checks
2011-12-08 6:49 [patch] sock_diag: off by one checks Dan Carpenter
@ 2011-12-08 9:07 ` Pavel Emelyanov
2011-12-09 0:54 ` David Miller
2011-12-09 0:54 ` David Miller
1 sibling, 1 reply; 4+ messages in thread
From: Pavel Emelyanov @ 2011-12-08 9:07 UTC (permalink / raw)
To: Dan Carpenter
Cc: David S. Miller, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org
On 12/08/2011 10:49 AM, Dan Carpenter wrote:
> These tests are off by one because sock_diag_handlers[] only has AF_MAX
> elements.
Oops :(
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Pavel Emelyanov <xemul@parallels.com>
> diff --git a/net/core/sock_diag.c b/net/core/sock_diag.c
> index fbaf01c..9c27bcd 100644
> --- a/net/core/sock_diag.c
> +++ b/net/core/sock_diag.c
> @@ -32,7 +32,7 @@ int sock_diag_register(struct sock_diag_handler *hndl)
> {
> int err = 0;
>
> - if (hndl->family > AF_MAX)
> + if (hndl->family >= AF_MAX)
> return -EINVAL;
>
> mutex_lock(&sock_diag_table_mutex);
> @@ -50,7 +50,7 @@ void sock_diag_unregister(struct sock_diag_handler *hnld)
> {
> int family = hnld->family;
>
> - if (family > AF_MAX)
> + if (family >= AF_MAX)
> return;
>
> mutex_lock(&sock_diag_table_mutex);
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [patch] sock_diag: off by one checks
2011-12-08 6:49 [patch] sock_diag: off by one checks Dan Carpenter
2011-12-08 9:07 ` Pavel Emelyanov
@ 2011-12-09 0:54 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2011-12-09 0:54 UTC (permalink / raw)
To: dan.carpenter; +Cc: xemul, netdev, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Thu, 8 Dec 2011 09:49:38 +0300
> These tests are off by one because sock_diag_handlers[] only has AF_MAX
> elements.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-12-09 0:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-08 6:49 [patch] sock_diag: off by one checks Dan Carpenter
2011-12-08 9:07 ` Pavel Emelyanov
2011-12-09 0:54 ` David Miller
2011-12-09 0:54 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).