From: David Miller <davem@davemloft.net>
To: dmitry@broadcom.com
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com, barak@broadcom.com
Subject: Re: [PATCH net-next] bnx2x: properly initialize L5 features
Date: Thu, 08 Dec 2011 19:56:12 -0500 (EST) [thread overview]
Message-ID: <20111208.195612.1797303038274788707.davem@davemloft.net> (raw)
In-Reply-To: <1323367447-28074-1-git-send-email-dmitry@broadcom.com>
From: "Dmitry Kravkov" <dmitry@broadcom.com>
Date: Thu, 8 Dec 2011 20:04:07 +0200
> The code is missing initialization of NO_FCOE_FLAG and NO_ISCSI*FLAGS
> when CONFIG_CNIC is not selected.
> This causes panic during driver load since commit
> 1d187b34daaecbb87aa523ba46b92930a388cb21 where NO_FCOE tested
> unconditionally (outside #ifdef BCM_CNIC structure) and
> accessed fp[FCOE_IDX] which is not allocated.
>
> Reported-by: Eric Dumazet <eric.dumazet@gmail.com>
> Signed-off-by: Dmitry Kravkov <dmitry@broadcom.com>
> Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
Applied.
prev parent reply other threads:[~2011-12-09 0:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-08 18:04 [PATCH net-next] bnx2x: properly initialize L5 features Dmitry Kravkov
2011-12-09 0:56 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111208.195612.1797303038274788707.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=barak@broadcom.com \
--cc=dmitry@broadcom.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).