From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: shemminger@vyatta.com, dave.taht@gmail.com,
netdev@vger.kernel.org, hagen@jauu.net
Subject: Re: [PATCH net-next] sch_red: generalize accurate MAX_P support to RED/GRED/CHOKE
Date: Fri, 09 Dec 2011 13:46:45 -0500 (EST) [thread overview]
Message-ID: <20111209.134645.470426835770901939.davem@davemloft.net> (raw)
In-Reply-To: <1323434805.2336.16.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 09 Dec 2011 13:46:45 +0100
> Now RED uses a Q0.32 number to store max_p (max probability), allow
> RED/GRED/CHOKE to use/report full resolution at config/dump time.
>
> Old tc binaries are non aware of new attributes, and still set/get Plog.
>
> New tc binary set/get both Plog and max_p for backward compatibility,
> they display "probability value" if they get max_p from new kernels.
>
> # tc -d qdisc show dev ...
> ...
> qdisc red 10: parent 1:1 limit 360Kb min 30Kb max 90Kb ecn ewma 5
> probability 0.09 Scell_log 15
>
> Make sure we avoid potential divides by 0 in reciprocal_value(), if
> (max_th - min_th) is big.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied, thanks.
next prev parent reply other threads:[~2011-12-09 18:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-05 9:05 Time in Queue, bufferbloat, and... our accidentally interplanetary network Dave Taht
2011-12-05 10:59 ` Eric Dumazet
2011-12-06 2:03 ` Adrian Chadd
[not found] ` <CAJ-VmomuA7u5=zRGMK2Jd3WG+HWTRTZNST4JDVWU9kUEcfE91Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-12-07 9:59 ` Dave Taht
2011-12-07 10:15 ` Hagen Paul Pfeifer
2011-12-07 10:19 ` Hagen Paul Pfeifer
2011-12-07 11:53 ` [Bloat] " Eric Dumazet
2011-12-08 16:06 ` [PATCH net-next] sch_red: Adaptative RED AQM Eric Dumazet
2011-12-08 17:21 ` Stephen Hemminger
2011-12-08 18:16 ` Eric Dumazet
2011-12-09 12:46 ` [PATCH net-next] sch_red: generalize accurate MAX_P support to RED/GRED/CHOKE Eric Dumazet
2011-12-09 18:46 ` David Miller [this message]
2011-12-09 0:55 ` [PATCH net-next] sch_red: Adaptative RED AQM David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111209.134645.470426835770901939.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dave.taht@gmail.com \
--cc=eric.dumazet@gmail.com \
--cc=hagen@jauu.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).