From: David Miller <davem@davemloft.net>
To: lw@cn.fujitsu.com
Cc: netdev@vger.kernel.org, yoshfuji@linux-ipv6.org
Subject: Re: [PATCH] ipv6: Fix for adding multicast route for loopback device automatically.
Date: Mon, 12 Dec 2011 18:49:29 -0500 (EST) [thread overview]
Message-ID: <20111212.184929.1998244574424635802.davem@davemloft.net> (raw)
In-Reply-To: <4EE00BAD.3010409@cn.fujitsu.com>
From: Li Wei <lw@cn.fujitsu.com>
Date: Thu, 08 Dec 2011 08:58:21 +0800
> The problem is that the resulting routing table depends on the sequence
> of interface's initialization and in some situation, that would block all
> muticast packets. Suppose there are two interfaces on my computer
> (lo and eth0), if we initailize 'lo' before 'eth0', the resuting routing
> table(for multicast) would be
>
> # ip -6 route show | grep ff00::
> unreachable ff00::/8 dev lo metric 256 error -101
> ff00::/8 dev eth0 metric 256
>
> When sending multicasting packets, routing subsystem will return the first
> route entry which with a error set to -101(ENETUNREACH).
>
> I know the kernel will set the default ipv6 address for 'lo' when it is up
> and won't set the default multicast route for it, but there is no reason to
> stop 'init' program from setting address for 'lo', and that is exactly what
> systemd did.
Ok, I added this more detailed explanation to the commit message and
applied your patch.
Probably it is a good idea to explain things completely, with all details
and examples, in the commit message from the beginning :-)
next prev parent reply other threads:[~2011-12-12 23:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-07 7:23 [PATCH] ipv6: Fix for adding multicast route for loopback device automatically Li Wei
2011-12-07 20:06 ` David Miller
2011-12-08 0:58 ` Li Wei
2011-12-12 23:49 ` David Miller [this message]
2011-12-13 0:56 ` Li Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111212.184929.1998244574424635802.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=lw@cn.fujitsu.com \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).