From: David Miller <davem@davemloft.net>
To: hagen@jauu.net
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com,
shemminger@vyatta.com, fw@strlen.de
Subject: Re: [PATCH] netem: add cell concept to simulate special MAC behavior
Date: Mon, 12 Dec 2011 19:01:32 -0500 (EST) [thread overview]
Message-ID: <20111212.190132.2127710068935598402.davem@davemloft.net> (raw)
In-Reply-To: <1323562314-14033-1-git-send-email-hagen@jauu.net>
From: Hagen Paul Pfeifer <hagen@jauu.net>
Date: Sun, 11 Dec 2011 01:11:54 +0100
> @@ -568,6 +585,12 @@ static void get_rate(struct Qdisc *sch, const struct nlattr *attr)
> const struct tc_netem_rate *r = nla_data(attr);
>
> q->rate = r->rate;
> + q->packet_overhead = r->packet_overhead;
> + q->cell_size = r->cell_size;
> + if (q->cell_size)
> + q->cell_size_reciprocal = reciprocal_value(q->cell_size);
> + q->cell_overhead = r->cell_overhead;
> }
>
> static int get_loss_clg(struct Qdisc *sch, const struct nlattr *attr)
This patch is corrupted. The hunk header here says there should be 6 lines
of content before the change and 12 lines afterwards, but there are only 11
lines of content afterwards.
Please fix this up and resubmit.
next prev parent reply other threads:[~2011-12-13 0:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-10 15:15 [PATCH net-next] netem: add cell concept to simulate special MAC behavior Hagen Paul Pfeifer
2011-12-10 16:43 ` Eric Dumazet
2011-12-10 23:36 ` [PATCH] " Hagen Paul Pfeifer
2011-12-10 23:58 ` Florian Westphal
2011-12-11 0:02 ` Hagen Paul Pfeifer
2011-12-11 0:08 ` Hagen Paul Pfeifer
2011-12-11 0:11 ` Hagen Paul Pfeifer
2011-12-12 17:19 ` Stephen Hemminger
2011-12-13 0:01 ` David Miller [this message]
2011-12-13 0:30 ` Hagen Paul Pfeifer
2011-12-13 0:45 ` David Miller
2011-12-12 17:18 ` [PATCH net-next] " Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111212.190132.2127710068935598402.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=fw@strlen.de \
--cc=hagen@jauu.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).