netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vasu Dev <vasu.dev@intel.com>
To: netdev@vger.kernel.org
Cc: jpirko@redhat.com, devel@open-fcoe.org
Subject: [PATCH] net: do not pass vlan pkts to real dev pkt handler also
Date: Mon, 12 Dec 2011 14:19:23 -0800	[thread overview]
Message-ID: <20111212221923.5356.43629.stgit@vifc.jf.intel.com> (raw)

The orig_dev has to be updated before going another round
for vlan pkts, otherwise currently unmodified real orig_dev
causes vlan pkt delivered to real orig_dev also.

The fcoe stack doesn't expects its vlan pkts on real dev
and it causes crash in fcoe stack.

This wasn't issue untill __netif_receive_skb recursive calling
was removed with this commit 0dfe178, so this patch restores
orig_dev uses as it was prior to that commit but still w/o
recursive calling to __netif_receive_skb.

Signed-off-by: Vasu Dev <vasu.dev@intel.com>
---

 net/core/dev.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/net/core/dev.c b/net/core/dev.c
index f494675..adbcd7a 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -3222,9 +3222,10 @@ ncls:
 			ret = deliver_skb(skb, pt_prev, orig_dev);
 			pt_prev = NULL;
 		}
-		if (vlan_do_receive(&skb, !rx_handler))
+		if (vlan_do_receive(&skb, !rx_handler)) {
+			orig_dev = skb->dev;
 			goto another_round;
-		else if (unlikely(!skb))
+		} else if (unlikely(!skb))
 			goto out;
 	}
 

             reply	other threads:[~2011-12-12 22:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-12 22:19 Vasu Dev [this message]
2011-12-12 22:56 ` [PATCH] net: do not pass vlan pkts to real dev pkt handler also Jiri Pirko
2011-12-13  1:08   ` Vasu Dev
2011-12-13 14:21     ` Jiri Pirko
2011-12-13 17:11       ` Vasu Dev
2011-12-13 21:45         ` Jiri Pirko
2011-12-14 19:52           ` Nicolas de Pesloüan
2011-12-14 23:55             ` Vasu Dev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111212221923.5356.43629.stgit@vifc.jf.intel.com \
    --to=vasu.dev@intel.com \
    --cc=devel@open-fcoe.org \
    --cc=jpirko@redhat.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).